This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8670

repoview: use the phasecache directly to determine mutable revisions
ClosedPublic

Authored by joerg.sonnenberger on Jun 27 2020, 7:08 PM.

Details

Reviewers
Alphare
durin42
Group Reviewers
hg-reviewers
Commits
rHG672ad1f6eeb8: repoview: use the phasecache directly to determine mutable revisions
Summary

This speeds up no-change updates from 1.3s to 0.85s for my NetBSD test
repository.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

joerg.sonnenberger added a comment.Jun 27 2020, 7:33 PM

Further analysis shows that the main issue here is that the topic exchange triggers a rebuild of the "served-topic" branchmap without a real reason. That doesn't mean the change isn't useful in general.

Alphare accepted this revision.Jul 1 2020, 11:20 AM
durin42 requested changes to this revision.Jul 1 2020, 2:29 PM
durin42 added a subscriber: durin42.

LGTM, but needs rebased.

This revision now requires changes to proceed.Jul 1 2020, 2:29 PM
joerg.sonnenberger added a comment.Jul 2 2020, 1:51 PM

phabsend didn't properly create a stack here, which is why it doesn't apply by itself.

pulkit added a subscriber: pulkit.Jul 7 2020, 2:02 PM

This one looks good as independent patch. Will be happy to push if you rebase it on default and send.

joerg.sonnenberger added a comment.Jul 12 2020, 4:51 PM

Rebased on top of the changeset that introduced hasnonpublicphases

joerg.sonnenberger added a commit: rHG672ad1f6eeb8: repoview: use the phasecache directly to determine mutable revisions.Jul 15 2020, 12:14 PM
This revision was not accepted when it landed; it landed in state Needs Revision.
Closed by commit rHG672ad1f6eeb8: repoview: use the phasecache directly to determine mutable revisions (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/repoview.py (4 lines)

Diff 21722

mercurial/repoview.py

else: else:
return hiddens return hiddens
def computemutable(repo, visibilityexceptions=None): def computemutable(repo, visibilityexceptions=None):
assert not repo.changelog.filteredrevs assert not repo.changelog.filteredrevs
# fast check to avoid revset call on huge repo # fast check to avoid revset call on huge repo
if repo._phasecache.hasnonpublicphases(repo): if repo._phasecache.hasnonpublicphases(repo):
getphase = repo._phasecache.phase return frozenset(repo._phasecache.getrevset(repo, phases.mutablephases))
maymutable = filterrevs(repo, b'base')
return frozenset(r for r in maymutable if getphase(repo, r))
return frozenset() return frozenset()
def computeimpactable(repo, visibilityexceptions=None): def computeimpactable(repo, visibilityexceptions=None):
"""Everything impactable by mutable revision """Everything impactable by mutable revision
The immutable filter still have some chance to get invalidated. This will The immutable filter still have some chance to get invalidated. This will
happen when: happen when: