This is an archive of the discontinued Mercurial Phabricator instance.

Differential D872

releasenotes: add test showing TypeError with no file specified
AbandonedPublic

Authored by durin42 on Oct 1 2017, 7:22 AM.

Details

Reviewers
pulkit
yuja
rishabhmadan96
Group Reviewers
hg-reviewers
Summary

The releasenotes command throws a TypeError when no filename is specified with
the --rev flag.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

rishabhmadan96 created this revision.Oct 1 2017, 7:22 AM
pulkit accepted this revision.Oct 1 2017, 9:09 AM
yuja accepted this revision.Oct 1 2017, 9:39 AM
yuja added a subscriber: yuja.

Folded into D877 since traceback message isn't reproducible.

This revision is now accepted and ready to land.Oct 1 2017, 9:39 AM
durin42 added a reviewer: rishabhmadan96.Oct 5 2017, 11:08 AM
durin42 commandeered this revision.
durin42 abandoned this revision.

was folded into D877 and landed

Revision Contents
Changeset List

PathPackages
Mtests/test-releasenotes-formatting.t (40 lines)

Diff 2247

tests/test-releasenotes-formatting.t

$ cd relnotes-raise-error $ cd relnotes-raise-error
$ hg releasenotes -r . -l $ hg releasenotes -r . -l
abort: cannot use both '--list' and '--rev' abort: cannot use both '--list' and '--rev'
[255] [255]
$ hg releasenotes -l -c $ hg releasenotes -l -c
abort: cannot use both '--list' and '--check' abort: cannot use both '--list' and '--check'
[255] [255]
Raise error when no filename is specified with --rev
$ hg init relnotes-nofile
$ cd relnotes-nofile
$ hg releasenote -r .
** unknown exception encountered, please report by visiting
** https://mercurial-scm.org/wiki/BugTracker
** Python 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]
** Mercurial Distributed SCM (version 4.3.3+701-c4594d38b2da+20171001)
** Extensions loaded: releasenotes
Traceback (most recent call last):
File "/tmp/hgtests.5N93rp/install/bin/hg", line 47, in <module>
dispatch.run()
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 81, in run
status = (dispatch(req) or 0) & 255
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 163, in dispatch
ret = _runcatch(req)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 303, in _runcatch
return _callcatch(ui, _runcatchfunc)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 311, in _callcatch
return scmutil.callcatch(ui, func)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/scmutil.py", line 151, in callcatch
return func()
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 293, in _runcatchfunc
return _dispatch(req)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 929, in _dispatch
cmdpats, cmdoptions)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 691, in runcommand
ret = _runcommand(ui, options, cmd, d)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 937, in _runcommand
return cmdfunc()
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/dispatch.py", line 926, in <lambda>
d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
File "/tmp/hgtests.5N93rp/install/lib/python/mercurial/util.py", line 1180, in check
return func(*args, **kwargs)
File "/tmp/hgtests.5N93rp/install/lib/python/hgext/releasenotes.py", line 580, in releasenotes
with open(file_, 'rb') as fh:
TypeError: coercing to Unicode: need string or buffer, NoneType found
[1]