( )⚙ D885 httppasswordmgrdbproxy: specify exact arguments

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D885

httppasswordmgrdbproxy: specify exact arguments
ClosedPublic

Authored by durin42 on Oct 1 2017, 12:43 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGae2fcf7af409: httppasswordmgrdbproxy: specify exact arguments
Summary

We only ever call these functions in a single way, so let's just
actually specify them. We need to do some string/bytes encoding
dancing here for Python 3, so it'll help to know what arguments we
need to convert.

no-check-commit because I'm modifying functions that check-commit

does not like.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 1 2017, 12:43 PM
yuja accepted this revision.Oct 2 2017, 5:33 AM
This revision is now accepted and ready to land.Oct 2 2017, 5:33 AM
Closed by commit rHGae2fcf7af409: httppasswordmgrdbproxy: specify exact arguments (authored by durin42). · Explain WhyOct 2 2017, 12:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (8 lines)

Diff 2297

mercurial/ui.py

def __init__(self): def __init__(self):
self._mgr = None self._mgr = None
def _get_mgr(self): def _get_mgr(self):
if self._mgr is None: if self._mgr is None:
self._mgr = urlreq.httppasswordmgrwithdefaultrealm() self._mgr = urlreq.httppasswordmgrwithdefaultrealm()
return self._mgr return self._mgr
def add_password(self, *args, **kwargs): def add_password(self, realm, uris, user, passwd):
return self._get_mgr().add_password(*args, **kwargs) return self._get_mgr().add_password(realm, uris, user, passwd)
def find_user_password(self, *args, **kwargs): def find_user_password(self, realm, uri):
return self._get_mgr().find_user_password(*args, **kwargs) return self._get_mgr().find_user_password(realm, uri)
def _catchterm(*args): def _catchterm(*args):
raise error.SignalInterrupt raise error.SignalInterrupt
# unique object used to detect no default value has been provided when # unique object used to detect no default value has been provided when
# retrieving configuration value. # retrieving configuration value.
_unset = object() _unset = object()