This is an archive of the discontinued Mercurial Phabricator instance.

tests: add test showing broken extension loading in case of share-safe
ClosedPublic

Authored by pulkit on Sep 18 2020, 10:40 AM.

Download Raw Diff

Details

Reviewers

indygreg
marmoute

Group Reviewers

hg-reviewers

Commits

rHGb1664f6eb650: tests: add test showing broken extension loading in case of share-safe

Summary

When we are using share-safe and loading source repository config, we are still
not loading the extensions which are enabled in the source repository.

This patch demonstrates the bug. Meanwhile it also shows how unreliable `hg
debugextensions` is.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

pulkit created this revision.Sep 18 2020, 10:40 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptSep 18 2020, 10:40 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

pulkit added a child revision: D9047: dispatch: load shared source repository config in share-safe mode.Sep 18 2020, 10:41 AM

indygreg accepted this revision.Sep 22 2020, 9:25 PM

This revision is now accepted and ready to land.Sep 22 2020, 9:25 PM

pulkit updated this revision to Diff 22772.Sep 23 2020, 3:22 AM

marmoute accepted this revision.Oct 16 2020, 6:20 AM

pulkit added a commit: rHGb1664f6eb650: tests: add test showing broken extension loading in case of share-safe.Oct 28 2020, 9:58 PM

Closed by commit rHGb1664f6eb650: tests: add test showing broken extension loading in case of share-safe (authored by pulkit). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-share-safe.t (39 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	22719		Sep 18 2020, 10:40 AM	★	★
Diff 2	22772		Sep 23 2020, 3:22 AM	★	★
Diff 3	23335	rHGb1664f6eb650962e81cff8cab941de432fba8ab9	Sep 18 2020, 7:58 AM	★	★

Commit	Parents	Author	Summary	Date
90e0e681dc5b	94f681b84c70	Pulkit Goyal		Sep 18 2020, 7:58 AM

Status	Author	Revision
Closed	pulkit	D9413 helptext: document share safe functionality in `hg help config -v`
Closed	pulkit	D9412 helptext: mention in `hg help config` that `.hg/hgrc-not-shared` is consulted
Closed	pulkit	D9411 share: add documentation about share-safe mode in `hg help -e share`
Closed	pulkit	D9410 helptext: update first hg version when share-safe will be released
Closed	pulkit	D9369 share: show warning if share is outdated while source supports share-safe
Closed	pulkit	D9360 commands: fix checking of share safe requirement on `config --shared`
Closed	pulkit	D9359 dispatch: pass root path in ui.readconfig() as root of main repo
Closed	pulkit	D9358 upgrade: add support to downgrade share safe mode
Closed	pulkit	D9357 scmutil: try-delete `.hg/store/requires` if store requirements are empty
Closed	pulkit	D9144 upgrade: add support for experimental safe share mode
Closed	pulkit	D8914 helptext: document exp-sharesafe in internals/requirements.txt
Closed	pulkit	D8673 config: add a .hg/hgrc-not-shared which won't be shared in share-safe mode
Closed	pulkit	D9047 dispatch: load shared source repository config in share-safe mode
Closed	pulkit	D9046 tests: add test showing broken extension loading in case of share-safe
Closed	pulkit	D9045 tests: update test-share-safe to work with non-zstd versions

Diff 22772

tests/test-share-safe.t

	[1]			[1]

	$ echo "[ui]" >> ../source/.hg/hgrc			$ echo "[ui]" >> ../source/.hg/hgrc
	$ echo "curses=true" >> ../source/.hg/hgrc			$ echo "curses=true" >> ../source/.hg/hgrc

	$ hg showconfig ui.curses			$ hg showconfig ui.curses
	true			true

				Test that extensions of source repository are also loaded

				$ hg debugextensions
				share
				$ hg extdiff -p echo
				hg: unknown command 'extdiff'
				'extdiff' is provided by the following extension:

				extdiff command to allow external programs to compare revisions

				(use 'hg help extensions' for information on enabling extensions)
				[255]

				$ echo "[extensions]" >> ../source/.hg/hgrc
				$ echo "extdiff=" >> ../source/.hg/hgrc

				$ hg debugextensions -R ../source
				extdiff
				share
				$ hg extdiff -R ../source -p echo

				BROKEN: the command below does not work but debugextensions says that extension
				is loaded
				$ hg debugextensions
				extdiff
				share

				BROKEN: extdiff command should work here
				$ hg extdiff -p echo
				hg: unknown command 'extdiff'
				'extdiff' is provided by the following extension:

				extdiff command to allow external programs to compare revisions

				(use 'hg help extensions' for information on enabling extensions)
				[255]

	However, local .hg/hgrc should override the config set by share source			However, local .hg/hgrc should override the config set by share source

	$ echo "[ui]" >> .hg/hgrc			$ echo "[ui]" >> .hg/hgrc
	$ echo "curses=false" >> .hg/hgrc			$ echo "curses=false" >> .hg/hgrc

	$ hg showconfig ui.curses			$ hg showconfig ui.curses
	false			false

	$ HGEDITOR=cat hg config --shared			$ HGEDITOR=cat hg config --shared
	[ui]			[ui]
	curses=true			curses=true
				[extensions]
				extdiff=

	$ HGEDITOR=cat hg config --local			$ HGEDITOR=cat hg config --local
	[ui]			[ui]
	curses=false			curses=false

	Testing that hooks set in source repository also runs in shared repo			Testing that hooks set in source repository also runs in shared repo

	$ cd ../source			$ cd ../source