Now that ParseErrors raised while reading the config file has been
converted into ConfigErrors, the remaining parse errors should all
be "input errors" (i.e. exit code 10), according to
https://www.mercurial-scm.org/wiki/ErrorCategoriesPlan.
Details
- Reviewers
durin42 mharbison72 - Group Reviewers
hg-reviewers - Commits
- rHGfc4fb2f17dd4: errors: use exit code 10 for parse errors
Diff Detail
- Repository
- rHG Mercurial
- Branch
- default
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
tests/test-config.t | ||
---|---|---|
11 | Should these be Configuration/30 like the plan page says? (I'm fine with queueing this and refining it later, since it looks like this is serviced by the same code that is obviously an input error in other cases.) I wondered similar about the .hgsub parse errors above, but that's arguably an input rather than a config file I guess. |
tests/test-config.t | ||
---|---|---|
11 | Good point. I'll see if I can refactor the code a bit so the ParseError gets converted to a ConfigError if it gets caught in the config code. |
tests/test-config.t | ||
---|---|---|
11 | This should now be done. I inserted 12 more patches before this one to handle the config errors. |
Should these be Configuration/30 like the plan page says? (I'm fine with queueing this and refining it later, since it looks like this is serviced by the same code that is obviously an input error in other cases.) I wondered similar about the .hgsub parse errors above, but that's arguably an input rather than a config file I guess.