This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9357

scmutil: try-delete `.hg/store/requires` if store requirements are empty
ClosedPublic

Authored by pulkit on Nov 21 2020, 8:07 AM.

Details

Reviewers
Alphare
mharbison72
Group Reviewers
hg-reviewers
Commits
rHGaba4f2c97e74: scmutil: try-delete `.hg/store/requires` if store requirements are empty
Summary

When downgrading from a shared-safe repository to non-shared-safe repository, we
end up in a case where we had requirements stored in .hg/store/requires but no
longer want them there.

Let's explicitly try delete the .hg/store/requires file is store requirements
are empty.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (3 lines)

Diff 23610

mercurial/scmutil.py

""" writes requirements for the repo to .hg/requires """ """ writes requirements for the repo to .hg/requires """
if requirements: if requirements:
repo.requirements = requirements repo.requirements = requirements
wcreq, storereq = filterrequirements(repo.requirements) wcreq, storereq = filterrequirements(repo.requirements)
if wcreq is not None: if wcreq is not None:
writerequires(repo.vfs, wcreq) writerequires(repo.vfs, wcreq)
if storereq is not None: if storereq is not None:
writerequires(repo.svfs, storereq) writerequires(repo.svfs, storereq)
elif repo.ui.configbool(b'format', b'usestore'):
# only remove store requires if we are using store
repo.svfs.tryunlink(b'requires')
def writerequires(opener, requirements): def writerequires(opener, requirements):
with opener(b'requires', b'w', atomictemp=True) as fp: with opener(b'requires', b'w', atomictemp=True) as fp:
for r in sorted(requirements): for r in sorted(requirements):
fp.write(b"%s\n" % r) fp.write(b"%s\n" % r)