( )⚙ D9439 dispatch: sort the loaded extension names in the bug report

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9439

dispatch: sort the loaded extension names in the bug report
ClosedPublic

Authored by mharbison72 on Nov 27 2020, 11:49 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd896c958e428: dispatch: sort the loaded extension names in the bug report
Summary

This makes a long list of extensions easier to read. On very rare occasion I've
seen issues where the load order mattered, however that info should still be
obtainable with hg config extensions.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/dispatch.py (2 lines)
Mtests/test-extension.t (8 lines)

Diff 23759

mercurial/dispatch.py

+ b'\n' + b'\n'
) )
sysversion = pycompat.sysbytes(sys.version).replace(b'\n', b'') sysversion = pycompat.sysbytes(sys.version).replace(b'\n', b'')
warning += ( warning += (
(_(b"** Python %s\n") % sysversion) (_(b"** Python %s\n") % sysversion)
+ (_(b"** Mercurial Distributed SCM (version %s)\n") % util.version()) + (_(b"** Mercurial Distributed SCM (version %s)\n") % util.version())
+ ( + (
_(b"** Extensions loaded: %s\n") _(b"** Extensions loaded: %s\n")
% b", ".join([x[0] for x in extensions.extensions()]) % b", ".join([x[0] for x in sorted(extensions.extensions())])
) )
) )
return warning return warning
def handlecommandexception(ui): def handlecommandexception(ui):
"""Produce a warning message for broken commands """Produce a warning message for broken commands

tests/test-extension.t

$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A) ** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A)
** which supports versions 1.9 of Mercurial. ** which supports versions 1.9 of Mercurial.
** Please disable "older" and try your action again. ** Please disable "older" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (version 2.2) ** Mercurial Distributed SCM (version 2.2)
** Extensions loaded: throw, older ** Extensions loaded: older, throw
One extension only tested with older, one only with newer versions: One extension only tested with older, one only with newer versions:
$ echo "util.version = lambda:b'2.1'" >> older.py $ echo "util.version = lambda:b'2.1'" >> older.py
$ rm -f older.pyc older.pyo $ rm -f older.pyc older.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A) ** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A)
** which supports versions 1.9 of Mercurial. ** which supports versions 1.9 of Mercurial.
** Please disable "older" and try your action again. ** Please disable "older" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (version 2.1) ** Mercurial Distributed SCM (version 2.1)
** Extensions loaded: throw, older ** Extensions loaded: older, throw
Older extension is tested with current version, the other only with newer: Older extension is tested with current version, the other only with newer:
$ echo "util.version = lambda:b'1.9.3'" >> older.py $ echo "util.version = lambda:b'1.9.3'" >> older.py
$ rm -f older.pyc older.pyo $ rm -f older.pyc older.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0 ** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0
** which supports versions 2.1 of Mercurial. ** which supports versions 2.1 of Mercurial.
** Please disable "throw" and try your action again. ** Please disable "throw" and try your action again.
** If that fixes the bug please report it to http://example.com/bts ** If that fixes the bug please report it to http://example.com/bts
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (version 1.9.3) ** Mercurial Distributed SCM (version 1.9.3)
** Extensions loaded: throw, older ** Extensions loaded: older, throw
Ability to point to a different point Ability to point to a different point
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> --config ui.supportcontact='Your Local Goat Lenders' throw 2>&1 | egrep '^\*\*' > --config ui.supportcontact='Your Local Goat Lenders' throw 2>&1 | egrep '^\*\*'
** unknown exception encountered, please report by visiting ** unknown exception encountered, please report by visiting
** Your Local Goat Lenders ** Your Local Goat Lenders
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: throw, older ** Extensions loaded: older, throw
Declare the version as supporting this hg version, show regular bts link: Declare the version as supporting this hg version, show regular bts link:
$ hgver=`hg debuginstall -T '{hgver}'` $ hgver=`hg debuginstall -T '{hgver}'`
$ echo 'testedwith = """'"$hgver"'"""' >> throw.py $ echo 'testedwith = """'"$hgver"'"""' >> throw.py
$ if [ -z "$hgver" ]; then $ if [ -z "$hgver" ]; then
> echo "unable to fetch a mercurial version. Make sure __version__ is correct"; > echo "unable to fetch a mercurial version. Make sure __version__ is correct";
> fi > fi
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo