Page MenuHomePhabricator

setup: when possible, build and bundle man pages
ClosedPublic

Authored by danchr on Dec 21 2020, 11:11 AM.

Details

Summary

This makes it so the manual pages are built as part of the Python
build, and includes them in any wheel generated. This should make
Python wheels a much more useful and complete way of distributing
Mercurial binaries.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

danchr created this revision.Dec 21 2020, 11:11 AM
marmoute accepted this revision.Fri, Jan 8, 11:00 AM
marmoute added a subscriber: marmoute.

This looks good.

setup.py
484

small nits: you are checking for None so use is not None please.

danchr updated this revision to Diff 24698.Sat, Jan 9, 10:27 PM
danchr marked an inline comment as done.Sat, Jan 9, 10:29 PM

This looks good.

I should note that I didn't remove the current infrastructure that builds the documentation in the Makefile.

setup.py
484

Done.

danchr edited the summary of this revision. (Show Details)Tue, Jan 12, 7:07 AM
danchr updated this revision to Diff 24712.
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

This breaks the build; could you please unapply it while I investigate?