This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9693

downgrade: if a compression is removed, consider that too
ClosedPublic

Authored by pulkit on Jan 8 2021, 1:45 PM.

Details

Reviewers
mharbison72
Group Reviewers
hg-reviewers
Commits
rHG1fcab88ab85c: downgrade: if a compression is removed, consider that too
Summary

For compression format variant, the result of fromrepo() and fromconfig() is
not a boolean and we have to actually equate those to find change.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jan 8 2021, 1:45 PM
mharbison72 requested changes to this revision.Jan 12 2021, 8:11 PM
mharbison72 added a subscriber: mharbison72.
mharbison72 added inline comments.
mercurial/upgrade_utils/actions.py
475

Should there be a continue in here for clarity/correctness?

This revision now requires changes to proceed.Jan 12 2021, 8:11 PM
pulkit added inline comments.Jan 13 2021, 4:41 AM
mercurial/upgrade_utils/actions.py
475

Agreed.

mharbison72 accepted this revision.Jan 13 2021, 12:11 PM
This revision is now accepted and ready to land.Jan 13 2021, 12:11 PM
pulkit added a commit: rHG1fcab88ab85c: downgrade: if a compression is removed, consider that too.Jan 13 2021, 12:14 PM
Closed by commit rHG1fcab88ab85c: downgrade: if a compression is removed, consider that too (authored by pulkit). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade_utils/actions.py (7 lines)

Diff 24789

mercurial/upgrade_utils/actions.py

def find_format_downgrades(repo): def find_format_downgrades(repo):
"""returns a list of format downgrades which will be performed on the repo """returns a list of format downgrades which will be performed on the repo
because of disabled config option for them""" because of disabled config option for them"""
downgrades = [] downgrades = []
for fv in allformatvariant: for fv in allformatvariant:
if fv.name == b'compression':
# If there is a compression change between repository
# and config, destination repository compression will change
# and current compression will be removed.
if fv.fromrepo(repo) != fv.fromconfig(repo):
downgrades.append(fv)
mharbison72Unsubmitted
Not Done

Should there be a continue in here for clarity/correctness?

mharbison72: Should there be a `continue` in here for clarity/correctness?
pulkitAuthorUnsubmitted
Done

Agreed.

pulkit: Agreed.
continue
# format variant exist in repo but does not exist in new repository # format variant exist in repo but does not exist in new repository
# config # config
if fv.fromrepo(repo) and not fv.fromconfig(repo): if fv.fromrepo(repo) and not fv.fromconfig(repo):
downgrades.append(fv) downgrades.append(fv)
return downgrades return downgrades