Page MenuHomePhabricator

upgrade: rename actions to upgrade_actions
ClosedPublic

Authored by pulkit on Dec 16 2020, 5:14 AM.

Details

Summary

The actions were a list of optimizations and format ugrades which will be
upgraded. This does not include things which will be downgraded.

Let's rename the variable for clarity. It now makes obvious that we don't have
any concrete information on what things are downgraded.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Dec 16 2020, 5:14 AM

Hum, we don't determine downgrade here ? When do we compute downgrade then ?

okay I see D9618 now. This makes me a bit confuse about the function in the current diff. What is that function about ? do we only use it for display purpose and not behavior purpose ? If so, what do we display during downgrade ?

okay I see D9618 now. This makes me a bit confuse about the function in the current diff. What is that function about ? do we only use it for display purpose and not behavior purpose ? If so, what do we display during downgrade ?

As the diff shows, right now we use it for a couple of purposes:

  1. Display purpose
  2. Checking whether some optimizations exist or not

During downgrade, we display the set of removed requirements.

A good part of the current upgrade code is coupled with diffing old and new requirements which I am planning to refactor in upcoming patches.

pulkit updated this revision to Diff 24545.Wed, Dec 30, 5:31 AM
marmoute accepted this revision.Thu, Jan 7, 6:59 PM
mharbison72 accepted this revision.Tue, Jan 12, 6:45 PM
This revision is now accepted and ready to land.Tue, Jan 12, 6:45 PM
This revision was automatically updated to reflect the committed changes.