actions: introduce function to calculate downgrades
ClosedPublic
Actions

Authored by pulkit on Dec 16 2020, 5:14 AM.

Details

Reviewers

marmoute
mharbison72

Group Reviewers

hg-reviewers

Commits

rHGc97d8e0406a6: actions: introduce function to calculate downgrades

Summary

An ugrade operation can also downgrade/remove some format variants. Before this
patch there was no clean way to find out all such variants which will be
removed. This patch adds a function for that.

It will be used in next patch.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Dec 16 2020, 5:14 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptDec 16 2020, 5:14 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

pulkit added a child revision: D9619: upgrade: introduce post upgrade and downgrade message for improvements.Dec 16 2020, 5:15 AM

marmoute mentioned this in D9616: upgrade: rename actions to upgrade_actions.Tue, Dec 22, 3:45 AM

pulkit updated this revision to Diff 24547.Wed, Dec 30, 5:31 AM

marmoute accepted this revision.Thu, Jan 7, 7:23 PM

mharbison72 accepted this revision.Tue, Jan 12, 6:45 PM

This revision is now accepted and ready to land.Tue, Jan 12, 6:45 PM

pulkit added a commit: rHGc97d8e0406a6: actions: introduce function to calculate downgrades.Tue, Jan 12, 6:53 PM

Closed by commit rHGc97d8e0406a6: actions: introduce function to calculate downgrades (authored by pulkit). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/upgrade_utils/actions.py (15 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	24304		Dec 16 2020, 5:14 AM	★	★
Diff 2	24547		Wed, Dec 30, 5:31 AM	★	★
Diff 3	24756	rHGc97d8e0406a6edc3a353dbb302824d05222f59b0	Dec 16 2020, 4:34 AM	★	★

Status	Author	Revision
Needs Review	pulkit	D9775 upgrade: update only requirements if we can
Needs Review	pulkit	D9774 engine: add `if True` to prepare for next patch
Needs Review	pulkit	D9773 test: unquiet few tests to demonstrate changes in upcoming patches
Needs Review	pulkit	D9772 upgrade: mark sharesafe improvement as only touching requirements
Needs Review	pulkit	D9771 actions: calculate what all parts does the operation touches
Needs Review	pulkit	D9770 upgrade: don't create store backup if `--no-backup` is passed
Needs Review	pulkit	D9677 upgrade: use copy+delete instead of rename while creating backup
Closed	pulkit	D9695 upgrade: don't perform anything if nothing to do
Closed	pulkit	D9676 upgrade: migrated -> upgraded in ui messages
Closed	pulkit	D9675 upgrade: remove unnecessary `is None` check
Closed	pulkit	D9674 engine: refactor code to replace stores in separate function
Closed	pulkit	D9694 upgrade: demonstrate that a no-op upgrade still performs everything
Closed	pulkit	D9693 downgrade: if a compression is removed, consider that too
Closed	pulkit	D9673 engine: prevent a function call for each store file
Closed	pulkit	D9672 engine: make hook point for extension a public function
Closed	pulkit	D9669 engine: prevent multiple checking of re-delta-multibase
Closed	pulkit	D9668 engine: pass upgrade operation inside `_perform_clone()`
Closed	pulkit	D9667 engine: pass upgrade operation inside _clonerevlogs()
Closed	pulkit	D9666 actions: store deltareuse mode of whole operation in UpgradeOperation
Closed	pulkit	D9665 engine: refactor how total dstsize is calculated
Closed	pulkit	D9619 upgrade: introduce post upgrade and downgrade message for improvements
Closed	pulkit	D9618 actions: introduce function to calculate downgrades
Closed	pulkit	D9617 debugupgraderepo: minor documentation fix
Closed	pulkit	D9616 upgrade: rename actions to upgrade_actions
Closed	pulkit	D9615 upgrade: move optimization addition to determineactions()
Closed	pulkit	D9614 upgrade: drop support for old style optimization names
Closed	pulkit	D9583 upgrade: add a missing space in status message
Closed	pulkit	D9664 actions: rename DEFICIENCY constant to FORMAT_VARIANT
Closed	pulkit	D9582 upgrade: rename finddeficiences() to find_format_upgrades()
Closed	pulkit	D9580 engine: unwrap a hard to understand for loop
Closed	pulkit	D9579 engine: refactor actual cloning code into separate function
Closed	pulkit	D9578 upgrade: move printing of unused optimizations to UpgradeOperation class
Closed	pulkit	D9577 upgrade: move `printrequirements()` to UpgradeOperation class
Closed	pulkit	D9576 upgrade: move `printoptimisations() to UpgradeOperation class
Closed	pulkit	D9575 upgrade: move `printupgradeactions()` to UpgradeOperation class
Closed	pulkit	D9574 upgrade: move `print_affected_revlogs()` to UpgradeOperation class

Diff 24756

View Options

mercurial/upgrade_utils/actions.py

actions: introduce function to calculate downgradesClosedPublicActions