This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9694

upgrade: demonstrate that a no-op upgrade still performs everything
ClosedPublic

Authored by pulkit on Jan 8 2021, 1:45 PM.

Details

Reviewers
mharbison72
Group Reviewers
hg-reviewers
Commits
rHG24bfd98978da: upgrade: demonstrate that a no-op upgrade still performs everything
Summary

An upgrade operation which is not adding or removing anything should ideally
error out. However, it does the whole cloning and everything. Next patch will
fix it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jan 8 2021, 1:45 PM
mharbison72 added a subscriber: mharbison72.Jan 12 2021, 8:50 PM
mharbison72 added inline comments.
tests/test-upgrade-repo.t
1681–1684

Added some globs here to keep the test running, since the next commit that removes all of this has a problem.

mharbison72 accepted this revision.Jan 12 2021, 8:51 PM
This revision is now accepted and ready to land.Jan 12 2021, 8:51 PM

Revision Contents
Changeset List

PathPackages
Mtests/test-upgrade-repo.t (39 lines)

Diff 24768

tests/test-upgrade-repo.t

exp-sidedata-flag exp-sidedata-flag
fncache fncache
generaldelta generaldelta
revlog-compression-zstd (zstd !) revlog-compression-zstd (zstd !)
revlogv1 revlogv1
sparserevlog sparserevlog
store store
$ hg debugsidedata -c 0 $ hg debugsidedata -c 0
Demonstrate that nothing to perform upgrade will still run all the way through
FIXME: this should return early
$ hg debugupgraderepo --run
upgrade will perform the following actions:
requirements
preserved: dotencode, exp-sidedata-flag, fncache, generaldelta, revlog-compression-zstd, revlogv1, sparserevlog, store
processed revlogs:
- all-filelogs
- changelog
- manifest
beginning upgrade...
repository locked and read-only
creating temporary repository to stage upgraded data: $TESTTMP/sparserevlogrepo/.hg/upgrade.* (glob)
(it is safe to interrupt this process any time before data migration completes)
migrating 3 total revisions (1 in filelogs, 1 in manifests, 1 in changelog)
migrating 297 bytes in store; 103 bytes tracked data
migrating 1 filelogs containing 1 revisions (64 bytes in store; 0 bytes tracked data)
finished migrating 1 filelog revisions across 1 filelogs; change in size: 0 bytes
migrating 1 manifests containing 1 revisions (110 bytes in store; 45 bytes tracked data)
finished migrating 1 manifest revisions across 1 manifests; change in size: 0 bytes
migrating changelog containing 1 revisions (123 bytes in store; 58 bytes tracked data)
finished migrating 1 changelog revisions; change in size: 0 bytes
finished migrating 3 total revisions; total change in store size: 0 bytes
copying phaseroots
data fully upgraded in a temporary repository
marking source repository as being upgraded; clients will be unable to read from repository
starting in-place swap of repository data
replaced files will be backed up at $TESTTMP/sparserevlogrepo/.hg/upgradebackup.* (glob)
replacing store...
store replacement complete; repository was inconsistent for *s (glob)
finalizing requirements file and making repository readable again
removing temporary repository $TESTTMP/sparserevlogrepo/.hg/upgrade.* (glob)
copy of old repository backed up at $TESTTMP/sparserevlogrepo/.hg/upgradebackup.* (glob)
mharbison72Unsubmitted
Not Done

Added some globs here to keep the test running, since the next commit that removes all of this has a problem.

mharbison72: Added some globs here to keep the test running, since the next commit that removes all of this…
the old repository will not be deleted; remove it to free up disk space once the upgraded repository is verified