This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9756

persistent-nodemap: rename the storage.revlog.nodemap.mmap option
ClosedPublic

Authored by marmoute on Jan 13 2021, 11:04 PM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7d096e5a5b90: persistent-nodemap: rename the storage.revlog.nodemap.mmap option
rHGcede7a1c84bd: persistent-nodemap: rename the storage.revlog.nodemap.mmap option
rHG2e8285fe8917: persistent-nodemap: rename the storage.revlog.nodemap.mmap option
Summary

Since the feature is publicly known as "persistent-nodemap" this seems better to
reference it as "persistent-nodemap" in related config too. So we rename the
option to storage.revlog.persistent-nodemap.mmap.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

Diff 24838

mercurial/configitems.py

coreconfigitem( coreconfigitem(
b'storage', b'storage',
b'revlog.optimize-delta-parent-choice', b'revlog.optimize-delta-parent-choice',
default=True, default=True,
alias=[(b'format', b'aggressivemergedeltas')], alias=[(b'format', b'aggressivemergedeltas')],
) )
# experimental as long as rust is experimental (or a C version is implemented) # experimental as long as rust is experimental (or a C version is implemented)
coreconfigitem( coreconfigitem(
b'storage', b'revlog.nodemap.mmap', default=True, experimental=True b'storage',
b'revlog.persistent-nodemap.mmap',
default=True,
experimental=True,
) )
# experimental as long as format.use-persistent-nodemap is. # experimental as long as format.use-persistent-nodemap is.
coreconfigitem( coreconfigitem(
b'storage', b'revlog.nodemap.mode', default=b'compat', experimental=True b'storage', b'revlog.nodemap.mode', default=b'compat', experimental=True
) )
coreconfigitem( coreconfigitem(
b'storage', b'storage',
b'revlog.reuse-external-delta', b'revlog.reuse-external-delta',

mercurial/localrepo.py

if requirementsmod.NARROW_REQUIREMENT in requirements: if requirementsmod.NARROW_REQUIREMENT in requirements:
options[b'enableellipsis'] = True options[b'enableellipsis'] = True
if ui.configbool(b'experimental', b'rust.index'): if ui.configbool(b'experimental', b'rust.index'):
options[b'rust.index'] = True options[b'rust.index'] = True
if requirementsmod.NODEMAP_REQUIREMENT in requirements: if requirementsmod.NODEMAP_REQUIREMENT in requirements:
options[b'persistent-nodemap'] = True options[b'persistent-nodemap'] = True
if ui.configbool(b'storage', b'revlog.nodemap.mmap'): if ui.configbool(b'storage', b'revlog.persistent-nodemap.mmap'):
options[b'persistent-nodemap.mmap'] = True options[b'persistent-nodemap.mmap'] = True
epnm = ui.config(b'storage', b'revlog.nodemap.mode') epnm = ui.config(b'storage', b'revlog.nodemap.mode')
options[b'persistent-nodemap.mode'] = epnm options[b'persistent-nodemap.mode'] = epnm
if ui.configbool(b'devel', b'persistent-nodemap'): if ui.configbool(b'devel', b'persistent-nodemap'):
options[b'devel-force-nodemap'] = True options[b'devel-force-nodemap'] = True
return options return options

tests/test-persistent-nodemap.t

revision in index: 5002 revision in index: 5002
revision in nodemap: 5002 revision in nodemap: 5002
Test code path without mmap Test code path without mmap
--------------------------- ---------------------------
$ echo bar > bar $ echo bar > bar
$ hg add bar $ hg add bar
$ hg ci -m 'bar' --config storage.revlog.nodemap.mmap=no $ hg ci -m 'bar' --config storage.revlog.persistent-nodemap.mmap=no
$ hg debugnodemap --check --config storage.revlog.nodemap.mmap=yes $ hg debugnodemap --check --config storage.revlog.persistent-nodemap.mmap=yes
revision in index: 5003 revision in index: 5003
revision in nodemap: 5003 revision in nodemap: 5003
$ hg debugnodemap --check --config storage.revlog.nodemap.mmap=no $ hg debugnodemap --check --config storage.revlog.persistent-nodemap.mmap=no
revision in index: 5003 revision in index: 5003
revision in nodemap: 5003 revision in nodemap: 5003
#if pure #if pure
$ hg debugnodemap --metadata $ hg debugnodemap --metadata
uid: ???????????????? (glob) uid: ???????????????? (glob)
tip-rev: 5002 tip-rev: 5002