This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9765

persistent-nodemap: enable the feature by default when using Rust
ClosedPublic

Authored by marmoute on Jan 13 2021, 11:05 PM.

Details

Reviewers
durin42
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHGcc3ad5c3af3b: persistent-nodemap: enable the feature by default when using Rust
Summary

As discussed at the 5.6 sprint, we can make it enabled by default, but only for
Rust installation.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jan 13 2021, 11:05 PM
marmoute planned changes to this revision.Jan 13 2021, 11:39 PM

They are a large amout ot test to update for this change.

pulkit added a subscriber: pulkit.Mar 10 2021, 4:19 AM

This needs to be updated and pushed since all the parent patches were already pushed.

pulkit added a comment.Apr 1 2021, 4:49 AM

Ping on this, let's get this ready and pushed for upcoming release.

marmoute added a comment.Apr 8 2021, 11:35 PM
In D9765#156614, @pulkit wrote:

Ping on this, let's get this ready and pushed for upcoming release.

This should be ready now.

Alphare accepted this revision.Apr 9 2021, 4:22 AM
baymax updated this revision to Diff 26768.Apr 9 2021, 5:28 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Apr 11 2021, 5:32 PM
This revision is now accepted and ready to land.Apr 11 2021, 5:32 PM

Revision Contents
Changeset List

Diff 24835

mercurial/configitems.py

b'usegeneraldelta', b'usegeneraldelta',
default=True, default=True,
) )
coreconfigitem( coreconfigitem(
b'format', b'format',
b'usestore', b'usestore',
default=True, default=True,
) )
def _persistent_nodemap_default():
"""compute `use-persistent-nodemap` default value
The feature is disabled unless a fast implementation is available.
"""
from . import policy
return policy.importrust('revlog') is not None
coreconfigitem( coreconfigitem(
b'format', b'format',
b'use-persistent-nodemap', b'use-persistent-nodemap',
default=False, default=_persistent_nodemap_default,
) )
coreconfigitem( coreconfigitem(
b'format', b'format',
b'exp-use-copies-side-data-changeset', b'exp-use-copies-side-data-changeset',
default=False, default=False,
experimental=True, experimental=True,
) )
coreconfigitem( coreconfigitem(

mercurial/helptext/config.txt

implemented in Rust, so people not using a version of Mercurial compiled implemented in Rust, so people not using a version of Mercurial compiled
with the Rust part might actually suffer some slowdown. For this reason, with the Rust part might actually suffer some slowdown. For this reason,
Such version will by default refuse to access such repositories. That Such version will by default refuse to access such repositories. That
behavior can be controlled by configuration. Check behavior can be controlled by configuration. Check
:hg:`help config.storage.revlog.persistent-nodemap.slowpath` for details. :hg:`help config.storage.revlog.persistent-nodemap.slowpath` for details.
Repository with this on-disk format require Mercurial version 5.4 or above. Repository with this on-disk format require Mercurial version 5.4 or above.
Disabled by default. By default this format variant is disabled if fast implementation is not
available and enabled by default if the fast implementation is available.
``usestore`` ``usestore``
Enable or disable the "store" repository format which improves Enable or disable the "store" repository format which improves
compatibility with systems that fold case or otherwise mangle compatibility with systems that fold case or otherwise mangle
filenames. Disabling this option will allow you to store longer filenames filenames. Disabling this option will allow you to store longer filenames
in some situations at the expense of compatibility. in some situations at the expense of compatibility.
Repositories with this on-disk format require Mercurial version 0.9.4. Repositories with this on-disk format require Mercurial version 0.9.4.

tests/test-persistent-nodemap.t

=================================== ===================================
Test the persistent on-disk nodemap Test the persistent on-disk nodemap
=================================== ===================================
#if no-rust
$ cat << EOF >> $HGRCPATH $ cat << EOF >> $HGRCPATH
> [format] > [format]
> use-persistent-nodemap=yes > use-persistent-nodemap=yes
> [devel] > [devel]
> persistent-nodemap=yes > persistent-nodemap=yes
> EOF > EOF
#endif
$ hg init test-repo --config storage.revlog.persistent-nodemap.slow-path=allow $ hg init test-repo --config storage.revlog.persistent-nodemap.slow-path=allow
$ cd test-repo $ cd test-repo
Check handling of the default slow-path value Check handling of the default slow-path value
#if no-pure no-rust #if no-pure no-rust
$ hg id $ hg id