( )⚙ D10013 hgtagsfnodes: refactor code to compute fnode into separate fn

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10013

hgtagsfnodes: refactor code to compute fnode into separate fn
ClosedPublic

Authored by pulkit on Feb 17 2021, 2:43 PM.

Details

Reviewers
Alphare
marmoute
Group Reviewers
hg-reviewers
Commits
rHG75832107ec07: hgtagsfnodes: refactor code to compute fnode into separate fn
Summary

I plan to use this code at one more place while fixing a bug caused by an
invalid fnode present in cache.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Feb 17 2021, 2:43 PM
Alphare accepted this revision.Feb 23 2021, 4:16 AM
marmoute accepted this revision.Mar 1 2021, 3:50 AM
marmoute added a subscriber: marmoute.

looks like a good clarification.

baymax updated this revision to Diff 26108.Mar 5 2021, 1:17 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit added a commit: rHG75832107ec07: hgtagsfnodes: refactor code to compute fnode into separate fn.Mar 8 2021, 3:25 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG75832107ec07: hgtagsfnodes: refactor code to compute fnode into separate fn (authored by pulkit). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/tags.py (11 lines)

Diff 25650

mercurial/tags.py

# If we get here, the entry is either missing or invalid. # If we get here, the entry is either missing or invalid.
if not computemissing: if not computemissing:
if record != _fnodesmissingrec: if record != _fnodesmissingrec:
return False return False
return None return None
fnode = self._computefnode(node)
self._writeentry(offset, properprefix, fnode)
return fnode
def _computefnode(self, node):
"""Finds the tag filenode for a node which is missing or invalid
in cache"""
ctx = self._repo[node]
rev = ctx.rev()
fnode = None fnode = None
cl = self._repo.changelog cl = self._repo.changelog
p1rev, p2rev = cl._uncheckedparentrevs(rev) p1rev, p2rev = cl._uncheckedparentrevs(rev)
p1node = cl.node(p1rev) p1node = cl.node(p1rev)
p1fnode = self.getfnode(p1node, computemissing=False) p1fnode = self.getfnode(p1node, computemissing=False)
if p2rev != nullrev: if p2rev != nullrev:
# There is some no-merge changeset where p1 is null and p2 is set # There is some no-merge changeset where p1 is null and p2 is set
# Processing them as merge is just slower, but still gives a good # Processing them as merge is just slower, but still gives a good
fnode = p1fnode fnode = p1fnode
if fnode is None: if fnode is None:
# Populate missing entry. # Populate missing entry.
try: try:
fnode = ctx.filenode(b'.hgtags') fnode = ctx.filenode(b'.hgtags')
except error.LookupError: except error.LookupError:
# No .hgtags file on this revision. # No .hgtags file on this revision.
fnode = nullid fnode = nullid
self._writeentry(offset, properprefix, fnode)
return fnode return fnode
def setfnode(self, node, fnode): def setfnode(self, node, fnode):
"""Set the .hgtags filenode for a given changeset.""" """Set the .hgtags filenode for a given changeset."""
assert len(fnode) == 20 assert len(fnode) == 20
ctx = self._repo[node] ctx = self._repo[node]
# Do a lookup first to avoid writing if nothing has changed. # Do a lookup first to avoid writing if nothing has changed.