( )⚙ D10794 revlog: use the new `entry` function in revlog.py

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10794

revlog: use the new `entry` function in revlog.py
ClosedPublic

Authored by marmoute on May 30 2021, 1:29 PM.

Details

Reviewers
indygreg
Alphare
Group Reviewers
hg-reviewers
Commits
rHG8230f0204eb8: revlog: use the new `entry` function in revlog.py
Summary

This just make the construction of the tuple clearer.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.May 30 2021, 1:29 PM
baymax updated this revision to Diff 28307.May 31 2021, 6:51 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision as: Alphare.May 31 2021, 10:43 AM
baymax updated this revision to Diff 28322.May 31 2021, 4:21 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28404.Jun 1 2021, 11:17 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28419.Jun 2 2021, 7:43 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28453.Jun 4 2021, 11:05 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28475.Jun 7 2021, 5:17 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG8230f0204eb8: revlog: use the new `entry` function in revlog.py.Jun 7 2021, 5:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG8230f0204eb8: revlog: use the new `entry` function in revlog.py (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (27 lines)

Diff 28453

mercurial/revlog.py

serialized_sidedata = comp_sidedata serialized_sidedata = comp_sidedata
else: else:
serialized_sidedata = b"" serialized_sidedata = b""
# Don't store the offset if the sidedata is empty, that way # Don't store the offset if the sidedata is empty, that way
# we can easily detect empty sidedata and they will be no different # we can easily detect empty sidedata and they will be no different
# than ones we manually add. # than ones we manually add.
sidedata_offset = 0 sidedata_offset = 0
e = ( e = revlogutils.entry(
revlogutils.offset_type(offset, flags), flags=flags,
deltainfo.deltalen, data_offset=offset,
textlen, data_compressed_length=deltainfo.deltalen,
deltainfo.base, data_uncompressed_length=textlen,
link, data_compression_mode=compression_mode,
p1r, data_delta_base=deltainfo.base,
p2r, link_rev=link,
node, parent_rev_1=p1r,
sidedata_offset, parent_rev_2=p2r,
len(serialized_sidedata), node_id=node,
compression_mode, sidedata_offset=sidedata_offset,
sidedata_compression_mode, sidedata_compressed_length=len(serialized_sidedata),
sidedata_compression_mode=sidedata_compression_mode,
) )
self.index.append(e) self.index.append(e)
entry = self.index.entry_binary(curr) entry = self.index.entry_binary(curr)
if curr == 0 and self._docket is None: if curr == 0 and self._docket is None:
header = self._format_flags | self._format_version header = self._format_flags | self._format_version
header = self.index.pack_header(header) header = self.index.pack_header(header)
entry = header + entry entry = header + entry