This is going to be clearer and easier to track than -1. Ultimately I would
like to get ride of this special value everywhere but in the lower level,
however we need to clarify the API first. This changeset is part of such
clarification.
Details
Details
- Reviewers
SimonSapin pulkit - Group Reviewers
hg-reviewers - Commits
- rHG3f13dfa1fa78: dirstate: introduce a symbolic constant for the AMBIGUOUS_TIME marker
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Branch
- default
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
Comment Actions
+1 for having a named constant but I’m not sure about the AMBIGUOUS_TIME name. mtime == -1 is used together with state == 'n' indeed to indicate an ambiguous time, but it also for other values of state where the mtime field is simply unused. In the later cases the time is not necessarily ambiguous, it’s just irrelevant.
Comment Actions
same feedback as for the previous one. Unless we have a much better name at hand, I don't think this is an issue since the goal is to make this dissapear.