( )⚙ D10977 dirstate: drop the last explicit `state` usage in the module

This is an archive of the discontinued Mercurial Phabricator instance.

dirstate: drop the last explicit `state` usage in the module
ClosedPublic

Authored by marmoute on Jul 4 2021, 5:52 PM.

Details

Summary

The internal detail of the state bytes is not longer exposed to the dirstate
layer.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 4 2021, 5:52 PM

Is this the same? Or could this entry be "added" or "merged" instead of just "normal"?

The test doesn't bark and this seems fine.

If this is merged, this will be fine, since we would overwrite merged with merged,

This would not be added since this function is called file that exists during a merge/update.

baymax updated this revision to Diff 28879.Jul 6 2021, 2:09 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28921.Jul 6 2021, 7:31 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Jul 8 2021, 10:49 AM
Alphare added a subscriber: Alphare.

Agreed, this ends up being technically more correct (even though it doesn't matter).

This revision is now accepted and ready to land.Jul 8 2021, 10:49 AM
baymax updated this revision to Diff 29008.Jul 8 2021, 11:03 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)