( )⚙ D11370 dirstate-item: implement `removed` in a simpler way

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11370

dirstate-item: implement `removed` in a simpler way
ClosedPublic

Authored by marmoute on Aug 27 2021, 1:11 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG774e235d13c3: dirstate-item: implement `removed` in a simpler way
Summary

We can simply use the underlying attribute.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Aug 27 2021, 1:11 PM
Alphare accepted this revision.Aug 30 2021, 5:52 AM
This revision is now accepted and ready to land.Aug 30 2021, 5:52 AM
baymax updated this revision to Diff 30147.Aug 30 2021, 9:00 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG774e235d13c3: dirstate-item: implement `removed` in a simpler way.Aug 30 2021, 9:05 AM
Closed by commit rHG774e235d13c3: dirstate-item: implement `removed` in a simpler way (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/pure/parsers.py (2 lines)

Diff 30126

mercurial/pure/parsers.py

This property seems like an abstraction leakage and should probably be This property seems like an abstraction leakage and should probably be
dealt in this class (or maybe the dirstatemap) directly. dealt in this class (or maybe the dirstatemap) directly.
""" """
return self.removed and self._clean_p2 return self.removed and self._clean_p2
@property @property
def removed(self): def removed(self):
"""True if the file has been removed""" """True if the file has been removed"""
return self.v1_state() == b'r' return not self._wc_tracked and (self._p1_tracked or self._p2_tracked)
@property @property
def merged_removed(self): def merged_removed(self):
"""True if the file has been removed, but was "merged" initially """True if the file has been removed, but was "merged" initially
This property seems like an abstraction leakage and should probably be This property seems like an abstraction leakage and should probably be
dealt in this class (or maybe the dirstatemap) directly. dealt in this class (or maybe the dirstatemap) directly.
""" """