This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	SimonSapin	D11546 dirstate-v2: Add internal documentation
Closed	SimonSapin	D11545 dirstate-v2: Move data file info in the docket closer together
Closed	marmoute	D11608 dirstate-item: drop the legacy new_normal constructor
Closed	marmoute	D11607 dirstate-item: replace call to new_possibly_dirty
Closed	marmoute	D11606 dirstate-item: replace a call to new_possibly_dirty
Closed	marmoute	D11605 dirstate-item: drop the legacy new_possibly_dirty constructor
Closed	marmoute	D11604 dirstate-item: replace call to new_possibly_dirty
Closed	marmoute	D11603 dirstate-item: drop the legacy new_from_p2 constructor
Closed	marmoute	D11602 dirstate-item: replace call to new_from_p2
Closed	marmoute	D11601 dirstate-item: drop the legacy new_added constructor
Closed	marmoute	D11600 dirstate-item: replace call to new_added
Closed	marmoute	D11599 dirstate-item: drop the legacy new_merged constructor
Closed	marmoute	D11598 dirstate-item: replace call to new_merged
Closed	marmoute	D11597 dirstate-item: drop the `merged` property
Closed	marmoute	D11596 dirstate-item: replace another usage of `merged`
Closed	marmoute	D11595 dirstate-item: replace a `merged` usage with `from_p2`
Closed	marmoute	D11594 dirstate-item: drop the `from_p2` property
Closed	marmoute	D11593 dirstate-item: directly use `p2_info` in `v1_size`
Closed	marmoute	D11592 dirstate-item: use the `p2_info` property to replace more verbose call
Closed	marmoute	D11591 status: process `from_p2` file the same as `merged` one
Closed	marmoute	D11590 dirstate: drop an incorrect comment
Closed	marmoute	D11589 dirstate: drop some duplicated code
Abandoned	pulkit	D11588 dirstate: drop some duplicated code
Closed	marmoute	D11587 dirstate: align the dirstate's API to the lower level ones
Closed	marmoute	D11586 dirstate-item: introduce a `p1_tracked` property
Closed	marmoute	D11585 dirstate-item: introduce a `p2_info` property that combine two others
Closed	marmoute	D11584 dirstate: narrow gathering of parent data
Closed	marmoute	D11583 dirstate: align the dirstatemap's API to the data change
Closed	marmoute	D11558 dirstate-v2: Store a bitfield on disk instead of v1-like state
Closed	marmoute	D11557 dirstate-item: change the internal storage and constructor value
Closed	marmoute	D11582 dirstatemap: drop legacy method on the dirstatemap wrapper
Closed	marmoute	D11581 dirstatemap: align the Rust wrapper implementation of `setparent`
Closed	marmoute	D11580 dirstatemap: fix copymap.pop in Rust to return the value it pops
Closed	marmoute	D11579 dirstate-item: implement `drop_merge_data` on the Rust DirstateItem
Closed	marmoute	D11578 dirstatemap: use a common implement for reset_state
Closed	marmoute	D11577 dirstatemap: add a common `_drop_entry` method for dirstatemap
Closed	marmoute	D11576 dirstatemap: use common code for set_clean
Closed	marmoute	D11575 dirstatemap: use common code for set_possibly_dirty
Closed	marmoute	D11574 dirstatemap: use a common implement for set_tracked
Closed	marmoute	D11573 dirstatemap: add a common `_insert_entry` method for dirstatemap
Closed	marmoute	D11572 dirstatemap: use a common implementation for `dirstatemap.set_untracked`
Closed	marmoute	D11571 dirstatemap: add a common `_refresh_entry` method for dirstatemap
Closed	marmoute	D11570 dirstatemap: create `_dirs_incr/_dirs_decr` methods on the common class
Closed	marmoute	D11569 dirstatemap: small rework of the `set_untracked` method
Closed	marmoute	D11568 dirstatemap: arrange methods by category
Closed	marmoute	D11567 dirstatemap: move a multiple simple functions in the common class
Closed	marmoute	D11566 dirstatemap: rename `_rustmap` to `_map`
Closed	marmoute	D11565 dirstatemap: use a common __init__ for dirstatemap
Closed	marmoute	D11564 dirstatemap: introduce a common base for the dirstatemap class

Diff 30568

rust/hg-cpython/src/dirstate/dirstate_map.rs

	) -> PyResult<Option<PyObject>> {			) -> PyResult<Option<PyObject>> {
	let key = key.extract::<PyBytes>(py)?;			let key = key.extract::<PyBytes>(py)?;
	match self			match self
	.inner(py)			.inner(py)
	.borrow_mut()			.borrow_mut()
	.copy_map_remove(HgPath::new(key.data(py)))			.copy_map_remove(HgPath::new(key.data(py)))
	.map_err(\|e\| v2_error(py, e))?			.map_err(\|e\| v2_error(py, e))?
	{			{
	Some(_) => Ok(None),			Some(copy) => Ok(Some(
				PyBytes::new(py, copy.as_bytes()).into_object(),
				)),
	None => Ok(default),			None => Ok(default),
	}			}
	}			}

	def copymapiter(&self) -> PyResult<CopyMapKeysIterator> {			def copymapiter(&self) -> PyResult<CopyMapKeysIterator> {
	let leaked_ref = self.inner(py).leak_immutable();			let leaked_ref = self.inner(py).leak_immutable();
	CopyMapKeysIterator::from_inner(			CopyMapKeysIterator::from_inner(
	py,			py,

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	30568		Oct 2 2021, 11:05 AM	★	★
Diff 2	30637	rHGbd5f7c61d69d9c4c089829c7327de738d6218553	Oct 1 2021, 6:44 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

dirstatemap: fix copymap.pop in Rust to return the value it popsClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30568

rust/hg-cpython/src/dirstate/dirstate_map.rs

dirstatemap: fix copymap.pop in Rust to return the value it pops
ClosedPublic

Revision Contents
Changeset List