Page MenuHomePhabricator

dirstate-v2: Separate HAS_FILE_MTIME and HAS_DIRECTORY_MTIME flags
ClosedPublic

Authored by SimonSapin on Oct 14 2021, 11:00 AM.

Details

Summary

Previously the same flag was used, with its meaning based on whether the node
otherwise identifies a file tracked anywhere.

In addition to being more explicit, this enables storing a directory mtime
if a given path used to be tracked in a parent commit (so the dirstate still
has data about it) but became a directory in the working copy.
(However this is not done yet as it would require a larger change,
replacing the dirstate_map::NodeData enum with struct fields.)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Oct 14 2021, 11:00 AM
pulkit accepted this revision.Oct 14 2021, 2:46 PM
This revision is now accepted and ready to land.Oct 14 2021, 2:46 PM