This is an archive of the discontinued Mercurial Phabricator instance.

dirstate-v2: adds two flag to track the presence of some unrecorded files
ClosedPublic

Authored by marmoute on Oct 18 2021, 2:18 AM.

Details

Summary

Right now, we don't record ignored or unknown files in the dirstate. However
the structure would allow it. So we introduce two flags that can be used to
clarify whether all unknown/ignored children are recorded or not. This will
allow for more information to be stored in the future if this end up being
relevant.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 18 2021, 2:18 AM
Alphare requested changes to this revision.Oct 18 2021, 12:00 PM
Alphare added a subscriber: Alphare.

After discussing this in a VC, we'll flip the logic to avoid double negatives

This revision now requires changes to proceed.Oct 18 2021, 12:00 PM
Alphare requested changes to this revision.Oct 19 2021, 3:58 AM

Aside from my one comment, the commit message should say "whether unknown/ignored children are recorded or not"

mercurial/cext/util.h
44

This should be dirstate_flag_all_ignored_recorded

This revision now requires changes to proceed.Oct 19 2021, 3:58 AM
marmoute edited the summary of this revision. (Show Details)Oct 19 2021, 4:35 AM
marmoute updated this revision to Diff 30888.
Alphare accepted this revision.Oct 19 2021, 8:08 AM
This revision is now accepted and ready to land.Oct 19 2021, 8:08 AM