This is an archive of the discontinued Mercurial Phabricator instance.

dirstate: make DirstateItem constructor accept fallback value

Authored by marmoute on Oct 18 2021, 9:20 PM.



This could arguably goes in the previous changeset, but I wanted to keep that
previous changeset small to focus more on the user code and the documentation.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 18 2021, 9:20 PM

LGTM, but I need someone to look at the rust code here too

Alphare requested changes to this revision.Oct 19 2021, 4:19 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.

Same as the previous changeset, shouldn't this be in flags directly?

This revision now requires changes to proceed.Oct 19 2021, 4:19 AM
marmoute added inline comments.Oct 19 2021, 4:23 AM

Yeah I actually it should (I remember saying this to myself and then forgetting about it).

marmoute updated this revision to Diff 30892.Oct 19 2021, 7:49 AM
Alphare accepted this revision.Oct 19 2021, 8:13 AM
This revision is now accepted and ready to land.Oct 19 2021, 8:13 AM