( )⚙ D12345 statprof: remove superfluous sys.version_info check

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12345

statprof: remove superfluous sys.version_info check
ClosedPublic

Authored by indygreg on Mar 3 2022, 10:30 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG37537a4d2695: statprof: remove superfluous sys.version_info check
Summary

Always true since we require Python 3 now.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 3 2022, 10:30 PM
Alphare accepted this revision.Mar 8 2022, 4:41 AM
This revision is now accepted and ready to land.Mar 8 2022, 4:41 AM
indygreg added a commit: rHG37537a4d2695: statprof: remove superfluous sys.version_info check.Mar 8 2022, 6:02 AM
Closed by commit rHG37537a4d2695: statprof: remove superfluous sys.version_info check (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/statprof.py (4 lines)

Diff 32557

mercurial/statprof.py

) )
) # file:function ) # file:function
function[4].sort(reverse=True, key=lambda i: i.selfseconds()) function[4].sort(reverse=True, key=lambda i: i.selfseconds())
for stat in function[4]: for stat in function[4]:
# only show line numbers for significant locations (>1% time spent) # only show line numbers for significant locations (>1% time spent)
if stat.selfpercent() > 1: if stat.selfpercent() > 1:
source = stat.site.getsource(25) source = stat.site.getsource(25)
if sys.version_info.major >= 3 and not isinstance( if not isinstance(source, bytes):
source, bytes
):
source = pycompat.bytestr(source) source = pycompat.bytestr(source)
stattuple = ( stattuple = (
stat.selfpercent(), stat.selfpercent(),
stat.selfseconds(), stat.selfseconds(),
stat.site.lineno, stat.site.lineno,
source, source,
) )