This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1288

dispatch: filter the repository depending on func.cmdtype
AbandonedPublic

Authored by pulkit on Nov 2 2017, 2:09 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

This patch adds support for filtering the repository on the basis of
func.cmdtype. After this patch, repo.filtername will be used to decide what
level of access the running command can has on hidden commits.

All this logic is behind a config flag experimental.directacess which defaults
to False.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Nov 2 2017, 2:09 PM
pulkit planned changes to this revision.Nov 22 2017, 8:24 PM
pulkit updated this revision to Diff 4096.Dec 4 2017, 9:17 AM
pulkit abandoned this revision.Dec 19 2017, 7:21 AM

Moved the logic to filter repository at command level. This is not required anymore.
This series is superseded by D1730 - D1735.

Revision Contents
Changeset List

PathPackages
Mmercurial/configitems.py (3 lines)
Mmercurial/dispatch.py (10 lines)

Diff 3208

mercurial/configitems.py

default=100, default=100,
) )
coreconfigitem('experimental', 'copytrace.sourcecommitlimit', coreconfigitem('experimental', 'copytrace.sourcecommitlimit',
default=100, default=100,
) )
coreconfigitem('experimental', 'crecordtest', coreconfigitem('experimental', 'crecordtest',
default=None, default=None,
) )
coreconfigitem('experimental', 'directaccess',
default=False,
)
coreconfigitem('experimental', 'editortmpinhg', coreconfigitem('experimental', 'editortmpinhg',
default=False, default=False,
) )
coreconfigitem('experimental', 'evolution', coreconfigitem('experimental', 'evolution',
default=list, default=list,
) )
coreconfigitem('experimental', 'evolution.allowdivergence', coreconfigitem('experimental', 'evolution.allowdivergence',
default=False, default=False,

mercurial/dispatch.py

pycompat, pycompat,
registrar, registrar,
scmutil, scmutil,
ui as uimod, ui as uimod,
util, util,
) )
unrecoverablewrite = registrar.command.unrecoverablewrite unrecoverablewrite = registrar.command.unrecoverablewrite
recoverablewrite = registrar.command.recoverablewrite
readonly = registrar.command.readonly
class request(object): class request(object):
def __init__(self, args, ui=None, repo=None, fin=None, fout=None, def __init__(self, args, ui=None, repo=None, fin=None, fout=None,
ferr=None, prereposetups=None): ferr=None, prereposetups=None):
self.args = args self.args = args
self.ui = ui self.ui = ui
self.repo = repo self.repo = repo
raise error.RepoError(_("no repository found in" raise error.RepoError(_("no repository found in"
" '%s' (.hg not found)") " '%s' (.hg not found)")
% pycompat.getcwd()) % pycompat.getcwd())
raise raise
if repo: if repo:
ui = repo.ui ui = repo.ui
if options['hidden']: if options['hidden']:
repo = repo.unfiltered() repo = repo.unfiltered()
# Accessing hidden commits based on func.cmdtype
if lui.configbool('experimental', 'directaccess'):
if func.cmdtype == readonly:
repo = repo.filtered('visible-hidden')
elif func.cmdtype == recoverablewrite:
repo = repo.filtered('visible-warnhidden')
args.insert(0, repo) args.insert(0, repo)
elif rpath: elif rpath:
ui.warn(_("warning: --repository ignored\n")) ui.warn(_("warning: --repository ignored\n"))
msg = _formatargs(fullargs) msg = _formatargs(fullargs)
ui.log("command", '%s\n', msg) ui.log("command", '%s\n', msg)
strcmdopt = pycompat.strkwargs(cmdoptions) strcmdopt = pycompat.strkwargs(cmdoptions)
d = lambda: util.checksignature(func)(ui, *args, **strcmdopt) d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)