( )⚙ D2191 narrowspec: consistently use set() to copy sets

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2191

narrowspec: consistently use set() to copy sets
ClosedPublic

Authored by durin42 on Feb 12 2018, 3:03 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGb8bbe589fd47: narrowspec: consistently use set() to copy sets
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 12 2018, 3:03 PM
indygreg accepted this revision.Feb 12 2018, 5:55 PM
This revision is now accepted and ready to land.Feb 12 2018, 5:55 PM
Closed by commit rHGb8bbe589fd47: narrowspec: consistently use set() to copy sets (authored by durin42). · Explain WhyFeb 12 2018, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowspec.py (2 lines)

Diff 5561

hgext/narrow/narrowspec.py

([], set(['path:.'])) ([], set(['path:.']))
>>> restrictpatterns({'f1/../f2/fc2'}, {}, ['f1','f2'], []) >>> restrictpatterns({'f1/../f2/fc2'}, {}, ['f1','f2'], [])
(set(['f2/fc2']), {}) (set(['f2/fc2']), {})
>>> restrictpatterns({'f1/../f3/fc3'}, {}, ['f1','f2'], []) >>> restrictpatterns({'f1/../f3/fc3'}, {}, ['f1','f2'], [])
([], set(['path:.'])) ([], set(['path:.']))
>>> restrictpatterns({'f1/$non_exitent_var'}, {}, ['f1','f2'], []) >>> restrictpatterns({'f1/$non_exitent_var'}, {}, ['f1','f2'], [])
(set(['f1/$non_exitent_var']), {}) (set(['f1/$non_exitent_var']), {})
""" """
res_excludes = req_excludes.copy() res_excludes = set(req_excludes)
res_excludes.update(repo_excludes) res_excludes.update(repo_excludes)
if not req_includes: if not req_includes:
res_includes = set(repo_includes) res_includes = set(repo_includes)
elif 'path:.' not in repo_includes: elif 'path:.' not in repo_includes:
res_includes = [] res_includes = []
for req_include in req_includes: for req_include in req_includes:
req_include = util.expandpath(util.normpath(req_include)) req_include = util.expandpath(util.normpath(req_include))
if req_include in repo_includes: if req_include in repo_includes: