This is an archive of the discontinued Mercurial Phabricator instance.

tests: use drawdag in test-rebase-collapse.t
ClosedPublic

Authored by martinvonz on Mar 21 2018, 2:10 PM.

Details

Summary

This makes the tests shorter (410 lines -> 240 lines), faster (17s ->
12s), and easier to read (the setup for each test case is just before
the test, and we can refer to commits by name).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Mar 21 2018, 2:10 PM
indygreg accepted this revision.Mar 21 2018, 7:23 PM
indygreg added a subscriber: indygreg.

This was hard to review. But I didn't see anything obviously wrong with this refactor.

tests/test-rebase-collapse.t
182

Are we really printing revision numbers here?!

This revision is now accepted and ready to land.Mar 21 2018, 7:23 PM
This revision was automatically updated to reflect the committed changes.