( )⚙ D2918 rebase: inline _makextrafn() now that we have only one caller

This is an archive of the discontinued Mercurial Phabricator instance.

rebase: inline _makextrafn() now that we have only one caller
ClosedPublic

Authored by martinvonz on Mar 21 2018, 2:10 PM.

Details

Summary

Also avoid even creating a function since we just end up calling it
right away.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 21 2018, 2:10 PM
indygreg accepted this revision.Mar 21 2018, 7:40 PM
indygreg added a subscriber: indygreg.

The ability to register extra functions seems like the important functionality here. And self.extrafns is preserved. So I don't think anyone will miss the old function.

This revision is now accepted and ready to land.Mar 21 2018, 7:40 PM
This revision was automatically updated to reflect the committed changes.