( )⚙ D3058 bundlerepo: use super() when calling file()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3058

bundlerepo: use super() when calling file()
ClosedPublic

Authored by indygreg on Apr 3 2018, 9:56 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGc68262401c8c: bundlerepo: use super() when calling file()
Summary

We should be calling the default method, not reimplementing it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 3 2018, 9:56 PM
durin42 accepted this revision.Apr 4 2018, 2:12 PM
This revision is now accepted and ready to land.Apr 4 2018, 2:12 PM
Closed by commit rHGc68262401c8c: bundlerepo: use super() when calling file() (authored by indygreg). · Explain WhyApr 4 2018, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundlerepo.py (2 lines)

Diff 7626

mercurial/bundlerepo.py

self._cgunpacker.seek(self.filestart) self._cgunpacker.seek(self.filestart)
self._cgfilespos = _getfilestarts(self._cgunpacker) self._cgfilespos = _getfilestarts(self._cgunpacker)
if f in self._cgfilespos: if f in self._cgfilespos:
self._cgunpacker.seek(self._cgfilespos[f]) self._cgunpacker.seek(self._cgfilespos[f])
linkmapper = self.unfiltered().changelog.rev linkmapper = self.unfiltered().changelog.rev
return bundlefilelog(self.svfs, f, self._cgunpacker, linkmapper) return bundlefilelog(self.svfs, f, self._cgunpacker, linkmapper)
else: else:
return filelog.filelog(self.svfs, f) return super(bundlerepository, self).file(f)
def close(self): def close(self):
"""Close assigned bundle file immediately.""" """Close assigned bundle file immediately."""
self._bundlefile.close() self._bundlefile.close()
if self.tempfile is not None: if self.tempfile is not None:
self.vfs.unlink(self.tempfile) self.vfs.unlink(self.tempfile)
if self._tempparent: if self._tempparent:
shutil.rmtree(self._tempparent, True) shutil.rmtree(self._tempparent, True)