( )⚙ D4994 tests: glob away some annoying py3 differences

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4994

tests: glob away some annoying py3 differences
ClosedPublic

Authored by durin42 on Oct 12 2018, 10:16 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc3b7d9c54edd: tests: glob away some annoying py3 differences
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 12 2018, 10:16 AM
pulkit accepted this revision.Oct 12 2018, 10:35 AM
durin42 updated this revision to Diff 11894.Oct 12 2018, 11:23 AM
durin42 updated this revision to Diff 11899.Oct 12 2018, 11:34 AM
Closed by commit rHGc3b7d9c54edd: tests: glob away some annoying py3 differences (authored by durin42). · Explain WhyOct 12 2018, 11:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-extension.t (6 lines)

Diff 11876

tests/test-extension.t

Even though the extension fails during uisetup, hg is still basically usable: Even though the extension fails during uisetup, hg is still basically usable:
$ hg --config extensions.baduisetup=$TESTTMP/baduisetup.py version $ hg --config extensions.baduisetup=$TESTTMP/baduisetup.py version
Traceback (most recent call last): Traceback (most recent call last):
File "*/mercurial/extensions.py", line *, in _runuisetup (glob) File "*/mercurial/extensions.py", line *, in _runuisetup (glob)
uisetup(ui) uisetup(ui)
File "$TESTTMP/baduisetup.py", line 2, in uisetup File "$TESTTMP/baduisetup.py", line 2, in uisetup
1/0 1/0
ZeroDivisionError: integer division or modulo by zero ZeroDivisionError: * by zero (glob)
*** failed to set up extension baduisetup: integer division or modulo by zero *** failed to set up extension baduisetup: * by zero (glob)
Mercurial Distributed SCM (version *) (glob) Mercurial Distributed SCM (version *) (glob)
(see https://mercurial-scm.org for more information) (see https://mercurial-scm.org for more information)
Copyright (C) 2005-* Matt Mackall and others (glob) Copyright (C) 2005-* Matt Mackall and others (glob)
This is free software; see the source for copying conditions. There is NO This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ cd .. $ cd ..
> def ext(*args, **opts): > def ext(*args, **opts):
> print(opts[b'opt'], flush=True) > print(opts[b'opt'], flush=True)
> EOF > EOF
$ cat > $TESTTMP/opt-unicode-default/.hg/hgrc << EOF $ cat > $TESTTMP/opt-unicode-default/.hg/hgrc << EOF
> [extensions] > [extensions]
> test_unicode_default_value = $TESTTMP/test_unicode_default_value.py > test_unicode_default_value = $TESTTMP/test_unicode_default_value.py
> EOF > EOF
$ hg -R $TESTTMP/opt-unicode-default dummy $ hg -R $TESTTMP/opt-unicode-default dummy
*** failed to import extension test_unicode_default_value from $TESTTMP/test_unicode_default_value.py: unicode u'value' found in cmdtable.dummy *** failed to import extension test_unicode_default_value from $TESTTMP/test_unicode_default_value.py: unicode *'value' found in cmdtable.dummy (glob)
*** (use b'' to make it byte string) *** (use b'' to make it byte string)
hg: unknown command 'dummy' hg: unknown command 'dummy'
(did you mean summary?) (did you mean summary?)
[255] [255]