This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5005

tests: expand our coverage of errors in Python 3 for bad extensions
ClosedPublic

Authored by durin42 on Oct 12 2018, 12:53 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG772c1145bcef: tests: expand our coverage of errors in Python 3 for bad extensions
rHG58ee456df096: tests: expand our coverage of errors in Python 3 for bad extensions
Summary

What a mess.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 12 2018, 12:53 PM
durin42 updated this revision to Diff 11916.Oct 12 2018, 12:57 PM
durin42 updated this revision to Diff 11919.Oct 12 2018, 1:20 PM
pulkit accepted this revision.Oct 13 2018, 5:49 AM
Closed by commit rHG58ee456df096: tests: expand our coverage of errors in Python 3 for bad extensions (authored by durin42). · Explain WhyOct 13 2018, 5:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-bad-extension.t (13 lines)

Diff 12021

tests/test-bad-extension.t

> EOF > EOF
$ hg -q help help 2>&1 |grep extension $ hg -q help help 2>&1 |grep extension
*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
*** failed to import extension badext2: No module named *badext2* (glob) *** failed to import extension badext2: No module named *badext2* (glob)
show traceback show traceback
$ hg -q help help --traceback 2>&1 | egrep ' extension|^Exception|Traceback|ImportError' $ hg -q help help --traceback 2>&1 | egrep ' extension|^Exception|Traceback|ImportError|ModuleNotFound'
*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
Traceback (most recent call last): Traceback (most recent call last):
Exception: bit bucket overflow Exception: bit bucket overflow
*** failed to import extension badext2: No module named *badext2* (glob) *** failed to import extension badext2: No module named *badext2* (glob)
Traceback (most recent call last): Traceback (most recent call last):
ImportError: No module named badext2 (no-py3k !) ImportError: No module named badext2 (no-py3k !)
ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
Traceback (most recent call last): (py3k !) Traceback (most recent call last): (py3k !)
ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3k !)
Traceback (most recent call last): (py3k !) Traceback (most recent call last): (py3k !)
ModuleNotFoundError: No module named 'badext2' (py3k !)
names of extensions failed to load can be accessed via extensions.notloaded() names of extensions failed to load can be accessed via extensions.notloaded()
$ cat <<EOF > showbadexts.py $ cat <<EOF > showbadexts.py
> from mercurial import commands, extensions, registrar > from mercurial import commands, extensions, registrar
> cmdtable = {} > cmdtable = {}
> command = registrar.command(cmdtable) > command = registrar.command(cmdtable)
> @command(b'showbadexts', norepo=True) > @command(b'showbadexts', norepo=True)
> def showbadexts(ui, *pats, **opts): > def showbadexts(ui, *pats, **opts):
> ui.write(b'BADEXTS: %s\n' % b' '.join(sorted(extensions.notloaded()))) > ui.write(b'BADEXTS: %s\n' % b' '.join(sorted(extensions.notloaded())))
> EOF > EOF
$ hg --config extensions.badexts=showbadexts.py showbadexts 2>&1 | grep '^BADEXTS' $ hg --config extensions.badexts=showbadexts.py showbadexts 2>&1 | grep '^BADEXTS'
BADEXTS: badext badext2 BADEXTS: badext badext2
#if no-extraextensions #if no-extraextensions
show traceback for ImportError of hgext.name if devel.debug.extensions is set show traceback for ImportError of hgext.name if devel.debug.extensions is set
$ (hg help help --traceback --debug --config devel.debug.extensions=yes 2>&1) \ $ (hg help help --traceback --debug --config devel.debug.extensions=yes 2>&1) \
> | grep -v '^ ' \ > | grep -v '^ ' \
> | egrep 'extension..[^p]|^Exception|Traceback|ImportError|not import' > | egrep 'extension..[^p]|^Exception|Traceback|ImportError|not import|ModuleNotFound'
debug.extensions: loading extensions debug.extensions: loading extensions
debug.extensions: - processing 5 entries debug.extensions: - processing 5 entries
debug.extensions: - loading extension: 'gpg' debug.extensions: - loading extension: 'gpg'
debug.extensions: > 'gpg' extension loaded in * (glob) debug.extensions: > 'gpg' extension loaded in * (glob)
debug.extensions: - validating extension tables: 'gpg' debug.extensions: - validating extension tables: 'gpg'
debug.extensions: - invoking registered callbacks: 'gpg' debug.extensions: - invoking registered callbacks: 'gpg'
debug.extensions: > callbacks completed in * (glob) debug.extensions: > callbacks completed in * (glob)
debug.extensions: - loading extension: 'badext' debug.extensions: - loading extension: 'badext'
*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
Traceback (most recent call last): Traceback (most recent call last):
Exception: bit bucket overflow Exception: bit bucket overflow
debug.extensions: - loading extension: 'baddocext' debug.extensions: - loading extension: 'baddocext'
debug.extensions: > 'baddocext' extension loaded in * (glob) debug.extensions: > 'baddocext' extension loaded in * (glob)
debug.extensions: - validating extension tables: 'baddocext' debug.extensions: - validating extension tables: 'baddocext'
debug.extensions: - invoking registered callbacks: 'baddocext' debug.extensions: - invoking registered callbacks: 'baddocext'
debug.extensions: > callbacks completed in * (glob) debug.extensions: > callbacks completed in * (glob)
debug.extensions: - loading extension: 'badext2' debug.extensions: - loading extension: 'badext2'
debug.extensions: - could not import hgext.badext2 (No module named *badext2*): trying hgext3rd.badext2 (glob) debug.extensions: - could not import hgext.badext2 (No module named *badext2*): trying hgext3rd.badext2 (glob)
Traceback (most recent call last): Traceback (most recent call last):
ImportError: No module named badext2 (no-py3k !) ImportError: No module named badext2 (no-py3k !)
ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
debug.extensions: - could not import hgext3rd.badext2 (No module named *badext2*): trying badext2 (glob) debug.extensions: - could not import hgext3rd.badext2 (No module named *badext2*): trying badext2 (glob)
Traceback (most recent call last): Traceback (most recent call last):
ImportError: No module named badext2 (no-py3k !) ImportError: No module named badext2 (no-py3k !)
ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
Traceback (most recent call last): (py3k !) Traceback (most recent call last): (py3k !)
ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3k !)
*** failed to import extension badext2: No module named *badext2* (glob) *** failed to import extension badext2: No module named *badext2* (glob)
Traceback (most recent call last): Traceback (most recent call last):
ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
Traceback (most recent call last): (py3k !) Traceback (most recent call last): (py3k !)
ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3k !)
Traceback (most recent call last): (py3k !) Traceback (most recent call last): (py3k !)
ModuleNotFoundError: No module named 'badext2' (py3k !)
ImportError: No module named badext2 (no-py3k !) ImportError: No module named badext2 (no-py3k !)
debug.extensions: > loaded 2 extensions, total time * (glob) debug.extensions: > loaded 2 extensions, total time * (glob)
debug.extensions: - loading configtable attributes debug.extensions: - loading configtable attributes
debug.extensions: - executing uisetup hooks debug.extensions: - executing uisetup hooks
debug.extensions: - running uisetup for 'gpg' debug.extensions: - running uisetup for 'gpg'
debug.extensions: > uisetup for 'gpg' took * (glob) debug.extensions: > uisetup for 'gpg' took * (glob)
debug.extensions: - running uisetup for 'baddocext' debug.extensions: - running uisetup for 'baddocext'
debug.extensions: > uisetup for 'baddocext' took * (glob) debug.extensions: > uisetup for 'baddocext' took * (glob)