This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	11913		Oct 12 2018, 12:53 PM	★	★
Diff 2	11916		Oct 12 2018, 12:57 PM	★	★
Diff 3	11919		Oct 12 2018, 1:19 PM	★	★
Diff 4	12021	rHG58ee456df096422f9d4368d3bcd7ced8b2fbb6dc	Oct 12 2018, 12:38 PM	★	★

Commit	Parents	Author	Summary	Date
		Augie Fackler		Oct 12 2018, 12:38 PM

Status	Author	Revision
Closed	durin42	D5055 py3: moar passing tests
Closed	durin42	D5054 releasenotes: fix remaining bytes/unicode issues caught by tests
Closed	durin42	D5053 relnotes: port to Python 3
Closed	durin42	D5006 py3: three new passing tests
Closed	durin42	D5005 tests: expand our coverage of errors in Python 3 for bad extensions
Closed	durin42	D5004 tests: add lots of globs and conditional output lines
Closed	durin42	D5003 tests: fix up test-bad-extension.t's inline extension
Closed	durin42	D5002 extensions: fix up many many debug logs that use %r
Closed	durin42	D5001 polib: update to latest release 1.0.7 (upstream rev d75ce6dbbc2a)
Abandoned	durin42	D4995 tests: disable one check on Python 3
Closed	durin42	D4994 tests: glob away some annoying py3 differences
Closed	durin42	D4993 tests: fix a repr on python3 in test-extension.t
Closed	durin42	D4992 tests: so many b prefixes in test-extension.t
Closed	durin42	D4991 tests: ensure print() statements in test-extension.t all flush
Closed	durin42	D4990 py3: another one started passing

Diff 11913

tests/test-bad-extension.t

	> EOF			> EOF

	$ hg -q help help 2>&1 \|grep extension			$ hg -q help help 2>&1 \|grep extension
	*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow			*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
	*** failed to import extension badext2: No module named badext2 (glob)			*** failed to import extension badext2: No module named badext2 (glob)

	show traceback			show traceback

	$ hg -q help help --traceback 2>&1 \| egrep ' extension\|^Exception\|Traceback\|ImportError'			$ hg -q help help --traceback 2>&1 \| egrep ' extension\|^Exception\|Traceback\|ImportError\|ModuleNotFound'
	*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow			*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
	Traceback (most recent call last):			Traceback (most recent call last):
	Exception: bit bucket overflow			Exception: bit bucket overflow
	*** failed to import extension badext2: No module named badext2 (glob)			*** failed to import extension badext2: No module named badext2 (glob)
	Traceback (most recent call last):			Traceback (most recent call last):
	ImportError: No module named badext2 (no-py3k !)			ImportError: No module named badext2 (no-py3k !)
				ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
	Traceback (most recent call last): (py3k !)			Traceback (most recent call last): (py3k !)
				ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3k !)
	Traceback (most recent call last): (py3k !)			Traceback (most recent call last): (py3k !)
				ModuleNotFoundError: No module named 'badext2' (py3k !)

	names of extensions failed to load can be accessed via extensions.notloaded()			names of extensions failed to load can be accessed via extensions.notloaded()

	$ cat <<EOF > showbadexts.py			$ cat <<EOF > showbadexts.py
	> from mercurial import commands, extensions, registrar			> from mercurial import commands, extensions, registrar
	> cmdtable = {}			> cmdtable = {}
	> command = registrar.command(cmdtable)			> command = registrar.command(cmdtable)
	> @command(b'showbadexts', norepo=True)			> @command(b'showbadexts', norepo=True)
	> def showbadexts(ui, pats, *opts):			> def showbadexts(ui, pats, *opts):
	> ui.write(b'BADEXTS: %s\n' % b' '.join(sorted(extensions.notloaded())))			> ui.write(b'BADEXTS: %s\n' % b' '.join(sorted(extensions.notloaded())))
	> EOF			> EOF
	$ hg --config extensions.badexts=showbadexts.py showbadexts 2>&1 \| grep '^BADEXTS'			$ hg --config extensions.badexts=showbadexts.py showbadexts 2>&1 \| grep '^BADEXTS'
	BADEXTS: badext badext2			BADEXTS: badext badext2

	#if no-extraextensions			#if no-extraextensions
	show traceback for ImportError of hgext.name if devel.debug.extensions is set			show traceback for ImportError of hgext.name if devel.debug.extensions is set

	$ (hg help help --traceback --debug --config devel.debug.extensions=yes 2>&1) \			$ (hg help help --traceback --debug --config devel.debug.extensions=yes 2>&1) \
	> \| grep -v '^ ' \			> \| grep -v '^ ' \
	> \| egrep 'extension..[^p]\|^Exception\|Traceback\|ImportError\|not import'			> \| egrep 'extension..[^p]\|^Exception\|Traceback\|ImportError\|not import\|ModuleNotFound'
	debug.extensions: loading extensions			debug.extensions: loading extensions
	debug.extensions: - processing 5 entries			debug.extensions: - processing 5 entries
	debug.extensions: - loading extension: 'gpg'			debug.extensions: - loading extension: 'gpg'
	debug.extensions: > 'gpg' extension loaded in * (glob)			debug.extensions: > 'gpg' extension loaded in * (glob)
	debug.extensions: - validating extension tables: 'gpg'			debug.extensions: - validating extension tables: 'gpg'
	debug.extensions: - invoking registered callbacks: 'gpg'			debug.extensions: - invoking registered callbacks: 'gpg'
	debug.extensions: > callbacks completed in * (glob)			debug.extensions: > callbacks completed in * (glob)
	debug.extensions: - loading extension: 'badext'			debug.extensions: - loading extension: 'badext'
	*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow			*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
	Traceback (most recent call last):			Traceback (most recent call last):
	Exception: bit bucket overflow			Exception: bit bucket overflow
	debug.extensions: - loading extension: 'baddocext'			debug.extensions: - loading extension: 'baddocext'
	debug.extensions: > 'baddocext' extension loaded in * (glob)			debug.extensions: > 'baddocext' extension loaded in * (glob)
	debug.extensions: - validating extension tables: 'baddocext'			debug.extensions: - validating extension tables: 'baddocext'
	debug.extensions: - invoking registered callbacks: 'baddocext'			debug.extensions: - invoking registered callbacks: 'baddocext'
	debug.extensions: > callbacks completed in * (glob)			debug.extensions: > callbacks completed in * (glob)
	debug.extensions: - loading extension: 'badext2'			debug.extensions: - loading extension: 'badext2'
	debug.extensions: - could not import hgext.badext2 (No module named badext2): trying hgext3rd.badext2 (glob)			debug.extensions: - could not import hgext.badext2 (No module named badext2): trying hgext3rd.badext2 (glob)
	Traceback (most recent call last):			Traceback (most recent call last):
	ImportError: No module named badext2 (no-py3k !)			ImportError: No module named badext2 (no-py3k !)
				ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
	debug.extensions: - could not import hgext3rd.badext2 (No module named badext2): trying badext2 (glob)			debug.extensions: - could not import hgext3rd.badext2 (No module named badext2): trying badext2 (glob)
	Traceback (most recent call last):			Traceback (most recent call last):
	ImportError: No module named badext2 (no-py3k !)			ImportError: No module named badext2 (no-py3k !)
	Traceback (most recent call last): (py3k !)			Traceback (most recent call last): (py3k !)
				ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
				Traceback (most recent call last): (py3k !)
				ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3k !)
	*** failed to import extension badext2: No module named badext2 (glob)			*** failed to import extension badext2: No module named badext2 (glob)
	Traceback (most recent call last):			Traceback (most recent call last):
				ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
	Traceback (most recent call last): (py3k !)			Traceback (most recent call last): (py3k !)
				ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3k !)
	Traceback (most recent call last): (py3k !)			Traceback (most recent call last): (py3k !)
				ModuleNotFoundError: No module named 'badext2' (py3k !)
	ImportError: No module named badext2 (no-py3k !)			ImportError: No module named badext2 (no-py3k !)
	debug.extensions: > loaded 2 extensions, total time * (glob)			debug.extensions: > loaded 2 extensions, total time * (glob)
	debug.extensions: - loading configtable attributes			debug.extensions: - loading configtable attributes
	debug.extensions: - executing uisetup hooks			debug.extensions: - executing uisetup hooks
	debug.extensions: - running uisetup for 'gpg'			debug.extensions: - running uisetup for 'gpg'
	debug.extensions: > uisetup for 'gpg' took * (glob)			debug.extensions: > uisetup for 'gpg' took * (glob)
	debug.extensions: - running uisetup for 'baddocext'			debug.extensions: - running uisetup for 'baddocext'
	debug.extensions: > uisetup for 'baddocext' took * (glob)			debug.extensions: > uisetup for 'baddocext' took * (glob)

This is an archive of the discontinued Mercurial Phabricator instance.

tests: expand our coverage of errors in Python 3 for bad extensionsClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11913

tests/test-bad-extension.t

tests: expand our coverage of errors in Python 3 for bad extensions
ClosedPublic

Revision Contents
Changeset List