This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4991

tests: ensure print() statements in test-extension.t all flush
ClosedPublic

Authored by durin42 on Oct 12 2018, 10:16 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG958b4c506d3a: tests: ensure print() statements in test-extension.t all flush
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 12 2018, 10:16 AM
pulkit accepted this revision.Oct 12 2018, 10:28 AM
pulkit added a comment.Oct 12 2018, 10:56 AM

This one leads to SyntaxError on Python 2. I suspect this is because of missing 'from future import print_function' but I am also confused how it works right now then.

indygreg added a subscriber: indygreg.Oct 12 2018, 11:15 AM
In D4991#74993, @pulkit wrote:

This one leads to SyntaxError on Python 2. I suspect this is because of missing 'from future import print_function' but I am also confused how it works right now then.

print() in Python 2.7 works. It just doesn't support the extra arguments unless you from __future__ import print_function.

durin42 updated this revision to Diff 11891.Oct 12 2018, 11:23 AM
durin42 updated this revision to Diff 11896.Oct 12 2018, 11:34 AM
pulkit accepted this revision.Oct 12 2018, 11:42 AM
Closed by commit rHG958b4c506d3a: tests: ensure print() statements in test-extension.t all flush (authored by durin42). · Explain WhyOct 12 2018, 11:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-extension.t (34 lines)

Diff 11905

tests/test-extension.t

Test basic extension support Test basic extension support
$ cat > unflush.py <<EOF
> import sys
> from mercurial import pycompat
> if pycompat.ispy3:
> # no changes required
> sys.exit(0)
> with open(sys.argv[1], 'rb') as f:
> data = f.read()
> with open(sys.argv[1], 'wb') as f:
> f.write(data.replace(b', flush=True', b''))
> EOF
$ cat > foobar.py <<EOF $ cat > foobar.py <<EOF
> import os > import os
> from mercurial import commands, registrar > from mercurial import commands, registrar
> cmdtable = {} > cmdtable = {}
> command = registrar.command(cmdtable) > command = registrar.command(cmdtable)
> configtable = {} > configtable = {}
> configitem = registrar.configitem(configtable) > configitem = registrar.configitem(configtable)
reposetup called for a (chg !) reposetup called for a (chg !)
ui == repo.ui (chg !) ui == repo.ui (chg !)
Foo Foo
$ echo 'barfoo = !' >> $HGRCPATH $ echo 'barfoo = !' >> $HGRCPATH
Check that extensions are loaded in phases: Check that extensions are loaded in phases:
$ cat > foo.py <<EOF $ cat > foo.py <<EOF
> from __future__ import print_function
> import os > import os
> name = os.path.basename(__file__).rsplit('.', 1)[0] > name = os.path.basename(__file__).rsplit('.', 1)[0]
> print("1) %s imported" % name) > print("1) %s imported" % name, flush=True)
> def uisetup(ui): > def uisetup(ui):
> print("2) %s uisetup" % name) > print("2) %s uisetup" % name, flush=True)
> def extsetup(): > def extsetup():
> print("3) %s extsetup" % name) > print("3) %s extsetup" % name, flush=True)
> def reposetup(ui, repo): > def reposetup(ui, repo):
> print("4) %s reposetup" % name) > print("4) %s reposetup" % name, flush=True)
> >
> bytesname = name.encode('utf-8') > bytesname = name.encode('utf-8')
> # custom predicate to check registration of functions at loading > # custom predicate to check registration of functions at loading
> from mercurial import ( > from mercurial import (
> registrar, > registrar,
> smartset, > smartset,
> ) > )
> revsetpredicate = registrar.revsetpredicate() > revsetpredicate = registrar.revsetpredicate()
> @revsetpredicate(bytesname, safe=True) # safe=True for query via hgweb > @revsetpredicate(bytesname, safe=True) # safe=True for query via hgweb
> def custompredicate(repo, subset, x): > def custompredicate(repo, subset, x):
> return smartset.baseset([r for r in subset if r in {0}]) > return smartset.baseset([r for r in subset if r in {0}])
> EOF > EOF
$ $PYTHON $TESTTMP/unflush.py foo.py
$ cp foo.py bar.py $ cp foo.py bar.py
$ echo 'foo = foo.py' >> $HGRCPATH $ echo 'foo = foo.py' >> $HGRCPATH
$ echo 'bar = bar.py' >> $HGRCPATH $ echo 'bar = bar.py' >> $HGRCPATH
Check normal command's load order of extensions and registration of functions Check normal command's load order of extensions and registration of functions
$ hg log -r "foo() and bar()" -q $ hg log -r "foo() and bar()" -q
$ mkdir $TESTTMP/libroot $ mkdir $TESTTMP/libroot
$ echo "s = 'libroot/ambig.py'" > $TESTTMP/libroot/ambig.py $ echo "s = 'libroot/ambig.py'" > $TESTTMP/libroot/ambig.py
$ mkdir $TESTTMP/libroot/mod $ mkdir $TESTTMP/libroot/mod
$ touch $TESTTMP/libroot/mod/__init__.py $ touch $TESTTMP/libroot/mod/__init__.py
$ echo "s = 'libroot/mod/ambig.py'" > $TESTTMP/libroot/mod/ambig.py $ echo "s = 'libroot/mod/ambig.py'" > $TESTTMP/libroot/mod/ambig.py
$ cat > $TESTTMP/libroot/mod/ambigabs.py <<EOF $ cat > $TESTTMP/libroot/mod/ambigabs.py <<EOF
> from __future__ import absolute_import > from __future__ import absolute_import, print_function
> import ambig # should load "libroot/ambig.py" > import ambig # should load "libroot/ambig.py"
> s = ambig.s > s = ambig.s
> EOF > EOF
$ cat > loadabs.py <<EOF $ cat > loadabs.py <<EOF
> import mod.ambigabs as ambigabs > import mod.ambigabs as ambigabs
> def extsetup(): > def extsetup():
> print('ambigabs.s=%s' % ambigabs.s) > print('ambigabs.s=%s' % ambigabs.s, flush=True)
> EOF > EOF
$ $PYTHON $TESTTMP/unflush.py loadabs.py
$ (PYTHONPATH=${PYTHONPATH}${PATHSEP}${TESTTMP}/libroot; hg --config extensions.loadabs=loadabs.py root) $ (PYTHONPATH=${PYTHONPATH}${PATHSEP}${TESTTMP}/libroot; hg --config extensions.loadabs=loadabs.py root)
ambigabs.s=libroot/ambig.py ambigabs.s=libroot/ambig.py
$TESTTMP/a $TESTTMP/a
#if no-py3k #if no-py3k
$ cat > $TESTTMP/libroot/mod/ambigrel.py <<EOF $ cat > $TESTTMP/libroot/mod/ambigrel.py <<EOF
> from __future__ import print_function
> import ambig # should load "libroot/mod/ambig.py" > import ambig # should load "libroot/mod/ambig.py"
> s = ambig.s > s = ambig.s
> EOF > EOF
$ cat > loadrel.py <<EOF $ cat > loadrel.py <<EOF
> import mod.ambigrel as ambigrel > import mod.ambigrel as ambigrel
> def extsetup(): > def extsetup():
> print('ambigrel.s=%s' % ambigrel.s) > print('ambigrel.s=%s' % ambigrel.s, flush=True)
> EOF > EOF
$ $PYTHON $TESTTMP/unflush.py loadrel.py
$ (PYTHONPATH=${PYTHONPATH}${PATHSEP}${TESTTMP}/libroot; hg --config extensions.loadrel=loadrel.py root) $ (PYTHONPATH=${PYTHONPATH}${PATHSEP}${TESTTMP}/libroot; hg --config extensions.loadrel=loadrel.py root)
ambigrel.s=libroot/mod/ambig.py ambigrel.s=libroot/mod/ambig.py
$TESTTMP/a $TESTTMP/a
#endif #endif
Check absolute/relative import of extension specific modules Check absolute/relative import of extension specific modules
$ mkdir $TESTTMP/extroot $ mkdir $TESTTMP/extroot
> pass > pass
> EOF > EOF
Prohibit the use of unicode strings as the default value of options Prohibit the use of unicode strings as the default value of options
$ hg init $TESTTMP/opt-unicode-default $ hg init $TESTTMP/opt-unicode-default
$ cat > $TESTTMP/test_unicode_default_value.py << EOF $ cat > $TESTTMP/test_unicode_default_value.py << EOF
> from __future__ import print_function
> from mercurial import registrar > from mercurial import registrar
> cmdtable = {} > cmdtable = {}
> command = registrar.command(cmdtable) > command = registrar.command(cmdtable)
> @command(b'dummy', [(b'', b'opt', u'value', u'help')], 'ext [OPTIONS]') > @command(b'dummy', [(b'', b'opt', u'value', u'help')], 'ext [OPTIONS]')
> def ext(*args, **opts): > def ext(*args, **opts):
> print(opts[b'opt']) > print(opts[b'opt'], flush=True)
> EOF > EOF
$ $PYTHON $TESTTMP/unflush.py $TESTTMP/test_unicode_default_value.py
$ cat > $TESTTMP/opt-unicode-default/.hg/hgrc << EOF $ cat > $TESTTMP/opt-unicode-default/.hg/hgrc << EOF
> [extensions] > [extensions]
> test_unicode_default_value = $TESTTMP/test_unicode_default_value.py > test_unicode_default_value = $TESTTMP/test_unicode_default_value.py
> EOF > EOF
$ hg -R $TESTTMP/opt-unicode-default dummy $ hg -R $TESTTMP/opt-unicode-default dummy
*** failed to import extension test_unicode_default_value from $TESTTMP/test_unicode_default_value.py: unicode u'value' found in cmdtable.dummy *** failed to import extension test_unicode_default_value from $TESTTMP/test_unicode_default_value.py: unicode u'value' found in cmdtable.dummy
*** (use b'' to make it byte string) *** (use b'' to make it byte string)
hg: unknown command 'dummy' hg: unknown command 'dummy'
(did you mean summary?) (did you mean summary?)
[255] [255]