The test now passes on Python 3. I'm going to do one follow-up where
I'll adjust some grep calls to improve our checking of things on
Python 3.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
The new quotes are from Python: they added the quotes in their import error messages.
| Path | Packages | |||
|---|---|---|---|---|
| M | tests/test-bad-extension.t (25 lines) |
| > hgext.gpg = | > hgext.gpg = | ||||
| > badext = $abspathexc | > badext = $abspathexc | ||||
| > baddocext = $abspathdoc | > baddocext = $abspathdoc | ||||
| > badext2 = | > badext2 = | ||||
| > EOF | > EOF | ||||
| $ hg -q help help 2>&1 |grep extension | $ hg -q help help 2>&1 |grep extension | ||||
| *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow | *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow | ||||
| *** failed to import extension badext2: No module named badext2 | *** failed to import extension badext2: No module named *badext2* (glob) | ||||
| show traceback | show traceback | ||||
| $ hg -q help help --traceback 2>&1 | egrep ' extension|^Exception|Traceback|ImportError' | $ hg -q help help --traceback 2>&1 | egrep ' extension|^Exception|Traceback|ImportError' | ||||
| *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow | *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow | ||||
| Traceback (most recent call last): | Traceback (most recent call last): | ||||
| Exception: bit bucket overflow | Exception: bit bucket overflow | ||||
| *** failed to import extension badext2: No module named badext2 | *** failed to import extension badext2: No module named *badext2* (glob) | ||||
| Traceback (most recent call last): | Traceback (most recent call last): | ||||
| ImportError: No module named badext2 | ImportError: No module named badext2 (no-py3k !) | ||||
| Traceback (most recent call last): (py3k !) | |||||
| Traceback (most recent call last): (py3k !) | |||||
| names of extensions failed to load can be accessed via extensions.notloaded() | names of extensions failed to load can be accessed via extensions.notloaded() | ||||
| $ cat <<EOF > showbadexts.py | $ cat <<EOF > showbadexts.py | ||||
| > from mercurial import commands, extensions, registrar | > from mercurial import commands, extensions, registrar | ||||
| > cmdtable = {} | > cmdtable = {} | ||||
| > command = registrar.command(cmdtable) | > command = registrar.command(cmdtable) | ||||
| > @command(b'showbadexts', norepo=True) | > @command(b'showbadexts', norepo=True) | ||||
| Traceback (most recent call last): | Traceback (most recent call last): | ||||
| Exception: bit bucket overflow | Exception: bit bucket overflow | ||||
| debug.extensions: - loading extension: 'baddocext' | debug.extensions: - loading extension: 'baddocext' | ||||
| debug.extensions: > 'baddocext' extension loaded in * (glob) | debug.extensions: > 'baddocext' extension loaded in * (glob) | ||||
| debug.extensions: - validating extension tables: 'baddocext' | debug.extensions: - validating extension tables: 'baddocext' | ||||
| debug.extensions: - invoking registered callbacks: 'baddocext' | debug.extensions: - invoking registered callbacks: 'baddocext' | ||||
| debug.extensions: > callbacks completed in * (glob) | debug.extensions: > callbacks completed in * (glob) | ||||
| debug.extensions: - loading extension: 'badext2' | debug.extensions: - loading extension: 'badext2' | ||||
| debug.extensions: - could not import hgext.badext2 (No module named badext2): trying hgext3rd.badext2 | debug.extensions: - could not import hgext.badext2 (No module named *badext2*): trying hgext3rd.badext2 (glob) | ||||
| Traceback (most recent call last): | Traceback (most recent call last): | ||||
| ImportError: No module named *badext2 (glob) | ImportError: No module named badext2 (no-py3k !) | ||||
| debug.extensions: - could not import hgext3rd.badext2 (No module named badext2): trying badext2 | debug.extensions: - could not import hgext3rd.badext2 (No module named *badext2*): trying badext2 (glob) | ||||
| Traceback (most recent call last): | Traceback (most recent call last): | ||||
| ImportError: No module named *badext2 (glob) | ImportError: No module named badext2 (no-py3k !) | ||||
| *** failed to import extension badext2: No module named badext2 | Traceback (most recent call last): (py3k !) | ||||
| Traceback (most recent call last): | *** failed to import extension badext2: No module named *badext2* (glob) | ||||
| ImportError: No module named badext2 | Traceback (most recent call last): | ||||
| Traceback (most recent call last): (py3k !) | |||||
| Traceback (most recent call last): (py3k !) | |||||
| ImportError: No module named badext2 (no-py3k !) | |||||
| debug.extensions: > loaded 2 extensions, total time * (glob) | debug.extensions: > loaded 2 extensions, total time * (glob) | ||||
| debug.extensions: - loading configtable attributes | debug.extensions: - loading configtable attributes | ||||
| debug.extensions: - executing uisetup hooks | debug.extensions: - executing uisetup hooks | ||||
| debug.extensions: - running uisetup for 'gpg' | debug.extensions: - running uisetup for 'gpg' | ||||
| debug.extensions: > uisetup for 'gpg' took * (glob) | debug.extensions: > uisetup for 'gpg' took * (glob) | ||||
| debug.extensions: - running uisetup for 'baddocext' | debug.extensions: - running uisetup for 'baddocext' | ||||
| debug.extensions: > uisetup for 'baddocext' took * (glob) | debug.extensions: > uisetup for 'baddocext' took * (glob) | ||||
| debug.extensions: > all uisetup took * (glob) | debug.extensions: > all uisetup took * (glob) | ||||
| debug.extensions: > extension gpg take a total of * to load (glob) | debug.extensions: > extension gpg take a total of * to load (glob) | ||||
| debug.extensions: extension loading complete | debug.extensions: extension loading complete | ||||
| #endif | #endif | ||||
| confirm that there's no crash when an extension's documentation is bad | confirm that there's no crash when an extension's documentation is bad | ||||
| $ hg help --keyword baddocext | $ hg help --keyword baddocext | ||||
| *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow | *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow | ||||
| *** failed to import extension badext2: No module named badext2 | *** failed to import extension badext2: No module named *badext2* (glob) | ||||
| Topics: | Topics: | ||||
| extensions Using Additional Features | extensions Using Additional Features | ||||