This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4995

tests: disable one check on Python 3
AbandonedPublic

Authored by durin42 on Oct 12 2018, 10:17 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Summary

I'm pretty confident this is caused by differences in Python 3's
demandimporter wherein it'll notice nonexistent modules earlier than
Python 2. As a result, let's just disable this check on Python 3.

The test now passes on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 12 2018, 10:17 AM
durin42 updated this revision to Diff 11895.Oct 12 2018, 11:23 AM
durin42 updated this revision to Diff 11900.Oct 12 2018, 11:34 AM
durin42 updated this revision to Diff 11997.Oct 13 2018, 3:28 AM
durin42 updated this revision to Diff 12025.Oct 13 2018, 6:06 AM
durin42 updated this revision to Diff 12048.Oct 13 2018, 7:57 AM
durin42 updated this revision to Diff 12069.Oct 13 2018, 9:03 AM
yuja added a subscriber: yuja.Oct 14 2018, 2:19 AM
I'm pretty confident this is caused by differences in Python 3's
demandimporter wherein it'll notice nonexistent modules earlier than
Python 2. As a result, let's just disable this check on Python 3.
The test now passes on Python 3.

The test passes on my Python 3.6.7rc1 (Debian sid) without no-py3k, and I
think it is the test written for Py3.

+#if demandimport no-py3k
+
See also issue5208 for detail about example case on Python 3.x.

durin42 abandoned this revision.Nov 13 2018, 2:03 PM

Revision Contents
Changeset List

PathPackages
Mcontrib/python3-whitelist (1 line)
Mtests/test-extension.t (4 lines)

Diff 12069

contrib/python3-whitelist

test-exchange-obsmarkers-case-D1.t test-exchange-obsmarkers-case-D1.t
test-exchange-obsmarkers-case-D2.t test-exchange-obsmarkers-case-D2.t
test-exchange-obsmarkers-case-D3.t test-exchange-obsmarkers-case-D3.t
test-exchange-obsmarkers-case-D4.t test-exchange-obsmarkers-case-D4.t
test-execute-bit.t test-execute-bit.t
test-export.t test-export.t
test-extdata.t test-extdata.t
test-extdiff.t test-extdiff.t
test-extension.t
test-extensions-afterloaded.t test-extensions-afterloaded.t
test-extensions-wrapfunction.py test-extensions-wrapfunction.py
test-extra-filelog-entry.t test-extra-filelog-entry.t
test-fetch.t test-fetch.t
test-filebranch.t test-filebranch.t
test-filecache.py test-filecache.py
test-filelog.py test-filelog.py
test-fileset-generated.t test-fileset-generated.t

tests/test-extension.t

LIB: this is extlibroot.recursedown.legacy.used LIB: this is extlibroot.recursedown.legacy.used
LIB: this is extlibroot.shadowing.used LIB: this is extlibroot.shadowing.used
REL: this is absextroot.xsub1.xsub2.used REL: this is absextroot.xsub1.xsub2.used
REL: this is absextroot.xsub1.xsub2.called.func() REL: this is absextroot.xsub1.xsub2.called.func()
REL: this relimporter imports 'this is absextroot.relimportee' REL: this relimporter imports 'this is absextroot.relimportee'
Examine whether sub-module is imported relatively as expected. Examine whether sub-module is imported relatively as expected.
#endif
#if demandimport no-py3k
See also issue5208 for detail about example case on Python 3.x. See also issue5208 for detail about example case on Python 3.x.
$ f -q $TESTTMP/extlibroot/lsub1/lsub2/notexist.py $ f -q $TESTTMP/extlibroot/lsub1/lsub2/notexist.py
$TESTTMP/extlibroot/lsub1/lsub2/notexist.py: file not found $TESTTMP/extlibroot/lsub1/lsub2/notexist.py: file not found
$ cat > $TESTTMP/notexist.py <<NO_CHECK_EOF $ cat > $TESTTMP/notexist.py <<NO_CHECK_EOF
> text = 'notexist.py at root is loaded unintentionally\n' > text = 'notexist.py at root is loaded unintentionally\n'
> NO_CHECK_EOF > NO_CHECK_EOF