( )⚙ D5121 procutil: port over windows encoding fixes from logtoprocess

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5121

procutil: port over windows encoding fixes from logtoprocess
ClosedPublic

Authored by durin42 on Oct 16 2018, 3:18 PM.

Details

Reviewers
mharbison72
indygreg
Group Reviewers
hg-reviewers
Commits
rHG8fab95aa5280: procutil: port over windows encoding fixes from logtoprocess
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 16 2018, 3:18 PM
mharbison72 accepted this revision.Oct 16 2018, 10:49 PM
mharbison72 added a subscriber: mharbison72.

LGTM, thanks.

indygreg accepted this revision.Oct 17 2018, 2:57 AM
This revision is now accepted and ready to land.Oct 17 2018, 2:57 AM
Closed by commit rHG8fab95aa5280: procutil: port over windows encoding fixes from logtoprocess (authored by durin42). · Explain WhyNov 5 2018, 2:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/utils/procutil.py (6 lines)

Diff 12177

mercurial/utils/procutil.py

DETACHED_PROCESS = 0x00000008 DETACHED_PROCESS = 0x00000008
_creationflags = DETACHED_PROCESS | subprocess.CREATE_NEW_PROCESS_GROUP _creationflags = DETACHED_PROCESS | subprocess.CREATE_NEW_PROCESS_GROUP
def runbgcommand(script, env, shell=False, stdout=None, stderr=None): def runbgcommand(script, env, shell=False, stdout=None, stderr=None):
'''Spawn a command without waiting for it to finish.''' '''Spawn a command without waiting for it to finish.'''
# we can't use close_fds *and* redirect stdin. I'm not sure that we # we can't use close_fds *and* redirect stdin. I'm not sure that we
# need to because the detached process has no console connection. # need to because the detached process has no console connection.
subprocess.Popen( subprocess.Popen(
script, shell=shell, env=env, close_fds=True, tonativestr(script),
creationflags=_creationflags, stdout=stdout, stderr=stderr) shell=shell, env=tonativeenv(env), close_fds=True,
creationflags=_creationflags, stdout=stdout,
stderr=stderr)
else: else:
def runbgcommand(cmd, env, shell=False, stdout=None, stderr=None): def runbgcommand(cmd, env, shell=False, stdout=None, stderr=None):
'''Spawn a command without waiting for it to finish.''' '''Spawn a command without waiting for it to finish.'''
# double-fork to completely detach from the parent process # double-fork to completely detach from the parent process
# based on http://code.activestate.com/recipes/278731 # based on http://code.activestate.com/recipes/278731
pid = os.fork() pid = os.fork()
if pid: if pid:
# Parent process # Parent process