Page MenuHomePhabricator

editor: file created for diff action should have .diff suffix
ClosedPublic

Authored by mbolin on Sep 1 2017, 4:03 PM.

Details

Summary

This is a follow-up to https://phab.mercurial-scm.org/D464 that introduced the
new file extension behavior. It erroneously changed .diff to .diff.hg.txt.

Test Plan

Verified make tests passes, particularly test-editor-filename.t.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mbolin created this revision.Sep 1 2017, 4:03 PM
mbolin updated this revision to Diff 1551.Sep 1 2017, 4:16 PM

Added integration test.

mbolin updated this revision to Diff 1556.Sep 1 2017, 4:29 PM

Remove bin/bash shebang as @quark says this should fix the FreeBSD issue and should generally be banned from integration tests.

yuja accepted this revision.Sep 2 2017, 8:18 AM

I dropped the shebang fix and queued, thanks.

tests/test-editor-filename.t
8

This works, but seems not nice to force the kernel to detect
the type of executable. I'll send a follow up.

This revision is now accepted and ready to land.Sep 2 2017, 8:18 AM
This revision was automatically updated to reflect the committed changes.