This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6802

flagprocessors: use _processflagsread in simple cases
ClosedPublic

Authored by marmoute on Sep 7 2019, 5:27 AM.

Details

Reviewers
yuja
durin42
indygreg
Group Reviewers
hg-reviewers
Commits
rHGa3665eed228f: flagprocessors: use _processflagsread in simple cases
Summary

When there are no ambiguity regarding the raw value, we can simply use the new
method.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Sep 7 2019, 5:27 AM
indygreg accepted this revision.Sep 7 2019, 1:01 PM
This revision is now accepted and ready to land.Sep 7 2019, 1:01 PM
marmoute added a commit: rHGa3665eed228f: flagprocessors: use _processflagsread in simple cases.Sep 7 2019, 1:03 PM
Closed by commit rHGa3665eed228f: flagprocessors: use _processflagsread in simple cases (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16440

hgext/remotefilelog/remotefilelog.py

store = self.repo.contentstore store = self.repo.contentstore
rawtext = store.get(self.filename, node) rawtext = store.get(self.filename, node)
if raw: if raw:
return rawtext return rawtext
flags = store.getmeta(self.filename, node).get(constants.METAKEYFLAG, 0) flags = store.getmeta(self.filename, node).get(constants.METAKEYFLAG, 0)
if flags == 0: if flags == 0:
return rawtext return rawtext
text, verifyhash = self._processflags(rawtext, flags, 'read') text, verifyhash = self._processflagsread(rawtext, flags)
return text return text
def rawdata(self, node): def rawdata(self, node):
return self.revision(node, raw=False) return self.revision(node, raw=False)
def _read(self, id): def _read(self, id):
"""reads the raw file blob from disk, cache, or server""" """reads the raw file blob from disk, cache, or server"""
fileservice = self.repo.fileservice fileservice = self.repo.fileservice