This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6810

revlog: use the new sidedata map return in the sidedata method
ClosedPublic

Authored by marmoute on Sep 7 2019, 5:28 AM.

Details

Reviewers
yuja
durin42
indygreg
Group Reviewers
hg-reviewers
Commits
rHG9d62f9fa332f: revlog: use the new sidedata map return in the sidedata method
Summary

So far things, seems logical.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Sep 7 2019, 5:28 AM
marmoute updated this revision to Diff 16476.Sep 9 2019, 5:23 PM
marmoute updated this revision to Diff 16491.Sep 9 2019, 7:08 PM
durin42 accepted this revision.Sep 17 2019, 2:10 PM
This revision is now accepted and ready to land.Sep 17 2019, 2:10 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (3 lines)

Diff 16630

mercurial/revlog.py

def sidedata(self, nodeorrev, _df=None): def sidedata(self, nodeorrev, _df=None):
"""a map of extra data related to the changeset but not part of the hash """a map of extra data related to the changeset but not part of the hash
This function currently return a dictionary. However, more advanced This function currently return a dictionary. However, more advanced
mapping object will likely be used in the future for a more mapping object will likely be used in the future for a more
efficient/lazy code. efficient/lazy code.
""" """
# XXX will actualy return data once storage is implemented. return self._revisiondata(nodeorrev, _df)[1]
return {}
def _revisiondata(self, nodeorrev, _df=None, raw=False): def _revisiondata(self, nodeorrev, _df=None, raw=False):
# deal with <nodeorrev> argument type # deal with <nodeorrev> argument type
if isinstance(nodeorrev, int): if isinstance(nodeorrev, int):
rev = nodeorrev rev = nodeorrev
node = self.node(rev) node = self.node(rev)
else: else:
node = nodeorrev node = nodeorrev