This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6823

flagprocessors: remove flagprocessorsmixin
ClosedPublic

Authored by marmoute on Sep 7 2019, 5:29 AM.

Details

Reviewers
yuja
durin42
indygreg
Group Reviewers
hg-reviewers
Commits
rHG73288e7abe9b: flagprocessors: remove flagprocessorsmixin
Summary

It became an empty shell.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Sep 7 2019, 5:29 AM
durin42 accepted this revision.Sep 9 2019, 1:53 PM
This revision is now accepted and ready to land.Sep 9 2019, 1:53 PM
marmoute updated this revision to Diff 16489.Sep 9 2019, 5:25 PM
marmoute updated this revision to Diff 16502.Sep 9 2019, 7:09 PM
marmoute added a commit: rHG73288e7abe9b: flagprocessors: remove flagprocessorsmixin.Sep 27 2019, 11:07 AM
Closed by commit rHG73288e7abe9b: flagprocessors: remove flagprocessorsmixin (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16643

hgext/remotefilelog/remotefilelog.py

missing = self._store.getmissing([(self._filename, node)]) missing = self._store.getmissing([(self._filename, node)])
return not bool(missing) return not bool(missing)
def __get__(self, node): def __get__(self, node):
if node not in self: if node not in self:
raise KeyError(node) raise KeyError(node)
return node return node
class remotefilelog(flagutil.flagprocessorsmixin): class remotefilelog(object):
_generaldelta = True _generaldelta = True
_flagserrorclass = error.RevlogError _flagserrorclass = error.RevlogError
def __init__(self, opener, path, repo): def __init__(self, opener, path, repo):
self.opener = opener self.opener = opener
self.filename = path self.filename = path
self.repo = repo self.repo = repo

mercurial/revlog.py

return index, getattr(index, 'nodemap', None), cache return index, getattr(index, 'nodemap', None), cache
def packentry(self, entry, node, version, rev): def packentry(self, entry, node, version, rev):
p = indexformatng_pack(*entry) p = indexformatng_pack(*entry)
if rev == 0: if rev == 0:
p = versionformat_pack(version) + p[4:] p = versionformat_pack(version) + p[4:]
return p return p
class revlog(flagutil.flagprocessorsmixin): class revlog(object):
""" """
the underlying revision storage object the underlying revision storage object
A revlog consists of two parts, an index and the revision data. A revlog consists of two parts, an index and the revision data.
The index is a file with a fixed record size containing The index is a file with a fixed record size containing
information on each revision, including its nodeid (hash), the information on each revision, including its nodeid (hash), the
nodeids of its parents, the position and offset of its data within nodeids of its parents, the position and offset of its data within

mercurial/revlogutils/flagutil.py

if flag not in REVIDX_FLAGS_ORDER: if flag not in REVIDX_FLAGS_ORDER:
msg = _("flag '%#x' undefined in REVIDX_FLAGS_ORDER.") % (flag) msg = _("flag '%#x' undefined in REVIDX_FLAGS_ORDER.") % (flag)
raise error.ProgrammingError(msg) raise error.ProgrammingError(msg)
if flag in flagprocessors: if flag in flagprocessors:
msg = _("cannot register multiple processors on flag '%#x'.") % (flag) msg = _("cannot register multiple processors on flag '%#x'.") % (flag)
raise error.Abort(msg) raise error.Abort(msg)
flagprocessors[flag] = processor flagprocessors[flag] = processor
class flagprocessorsmixin(object):
"""basic mixin to support revlog flag processing
Make sure the `_flagprocessors` attribute is set at ``__init__`` time.
See the documentation of the ``_processflags`` method for details.
"""
def processflagswrite(revlog, text, flags, sidedata): def processflagswrite(revlog, text, flags, sidedata):
"""Inspect revision data flags and applies write transformations defined """Inspect revision data flags and applies write transformations defined
by registered flag processors. by registered flag processors.
``text`` - the revision data to process ``text`` - the revision data to process
``flags`` - the revision flags ``flags`` - the revision flags
This method processes the flags in the order (or reverse order if This method processes the flags in the order (or reverse order if

tests/simplestorerepo.py

@interfaceutil.implementer(repository.iverifyproblem) @interfaceutil.implementer(repository.iverifyproblem)
@attr.s(frozen=True) @attr.s(frozen=True)
class simplefilestoreproblem(object): class simplefilestoreproblem(object):
warning = attr.ib(default=None) warning = attr.ib(default=None)
error = attr.ib(default=None) error = attr.ib(default=None)
node = attr.ib(default=None) node = attr.ib(default=None)
@interfaceutil.implementer(repository.ifilestorage) @interfaceutil.implementer(repository.ifilestorage)
class filestorage(flagutil.flagprocessorsmixin): class filestorage(object):
"""Implements storage for a tracked path. """Implements storage for a tracked path.
Data is stored in the VFS in a directory corresponding to the tracked Data is stored in the VFS in a directory corresponding to the tracked
path. path.
Index data is stored in an ``index`` file using CBOR. Index data is stored in an ``index`` file using CBOR.
Fulltext data is stored in files having names of the node. Fulltext data is stored in files having names of the node.