( )⚙ D6841 uncommit: drop the hyphen from --current-user and --current-date

This is an archive of the discontinued Mercurial Phabricator instance.

uncommit: drop the hyphen from --current-user and --current-date
ClosedPublic

Authored by mharbison72 on Sep 10 2019, 11:24 PM.

Details

Summary

I didn't pay enough attention to these long forms- graft, amend and MQ already
use the old style naming. It's probably more important to be consistent than
modern. The hypenated style came from evolve.

Yuya mentioned this naming discrepancy in 4145fd3569c3, but it didn't attract
any discussion[1]. There's also a bit of inconsistency in that the default
parameter for currentdate is False for graft, and None for the rest.

[1] https://www.mercurial-scm.org/pipermail/mercurial-devel/2019-January/126767.html

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped