This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7042

phabricator: add the phabhunk data structure
ClosedPublic

Authored by Kwan on Oct 10 2019, 5:51 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG73d4bc60e389: phabricator: add the phabhunk data structure
Summary

These store the actual diff data (for UTF-8 text files anyway) and are
equivalent to hunks in a patch file.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Oct 10 2019, 5:51 PM
Kwan updated this revision to Diff 17073.Oct 11 2019, 1:54 PM

Fix some test-check-code issues, and one test-check-pyflakes unused local.

indygreg accepted this revision.Oct 11 2019, 9:43 PM
This revision is now accepted and ready to land.Oct 11 2019, 9:43 PM
Kwan added a commit: rHG73d4bc60e389: phabricator: add the phabhunk data structure.Oct 11 2019, 9:56 PM
Closed by commit rHG73d4bc60e389: phabricator: add the phabhunk data structure (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (16 lines)

Diff 17090

hgext/phabricator.py

import itertools import itertools
import json import json
import operator import operator
import re import re
from mercurial.node import bin, nullid from mercurial.node import bin, nullid
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial.pycompat import getattr from mercurial.pycompat import getattr
from mercurial.thirdparty import attr
from mercurial import ( from mercurial import (
cmdutil, cmdutil,
context, context,
encoding, encoding,
error, error,
exthelper, exthelper,
httpconnection as httpconnectionmod, httpconnection as httpconnectionmod,
mdiff, mdiff,
class DiffFileType(object): class DiffFileType(object):
TEXT = 1 TEXT = 1
IMAGE = 2 IMAGE = 2
BINARY = 3 BINARY = 3
@attr.s
class phabhunk(dict):
"""Represents a Differential hunk, which is owned by a Differential change
"""
oldOffset = attr.ib(default=0) # camelcase-required
oldLength = attr.ib(default=0) # camelcase-required
newOffset = attr.ib(default=0) # camelcase-required
newLength = attr.ib(default=0) # camelcase-required
corpus = attr.ib(default='')
# These get added to the phabchange's equivalents
addLines = attr.ib(default=0) # camelcase-required
delLines = attr.ib(default=0) # camelcase-required
def creatediff(ctx): def creatediff(ctx):
"""create a Differential Diff""" """create a Differential Diff"""
repo = ctx.repo() repo = ctx.repo()
repophid = getrepophid(repo) repophid = getrepophid(repo)
# Create a "Differential Diff" via "differential.createrawdiff" API # Create a "Differential Diff" via "differential.createrawdiff" API
params = {b'diff': getdiff(ctx, mdiff.diffopts(git=True, context=32767))} params = {b'diff': getdiff(ctx, mdiff.diffopts(git=True, context=32767))}
if repophid: if repophid:
params[b'repositoryPHID'] = repophid params[b'repositoryPHID'] = repophid