This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7043

phabricator: add the phabchange data structure
ClosedPublic

Authored by Kwan on Oct 10 2019, 5:52 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG99ee4afd352f: phabricator: add the phabchange data structure
Summary

These store data about individual files in a commit.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Kwan created this revision.Oct 10 2019, 5:52 PM
Kwan updated this revision to Diff 17074.Oct 11 2019, 1:54 PM

Fix some test-check-code issues, and one test-check-pyflakes unused local.

indygreg accepted this revision.Oct 11 2019, 9:44 PM
This revision is now accepted and ready to land.Oct 11 2019, 9:44 PM
Kwan added a commit: rHG99ee4afd352f: phabricator: add the phabchange data structure.Oct 11 2019, 9:56 PM
Closed by commit rHG99ee4afd352f: phabricator: add the phabchange data structure (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (41 lines)

Diff 17074

hgext/phabricator.py

newOffset = attr.ib(default=0) # camelcase-required newOffset = attr.ib(default=0) # camelcase-required
newLength = attr.ib(default=0) # camelcase-required newLength = attr.ib(default=0) # camelcase-required
corpus = attr.ib(default='') corpus = attr.ib(default='')
# These get added to the phabchange's equivalents # These get added to the phabchange's equivalents
addLines = attr.ib(default=0) # camelcase-required addLines = attr.ib(default=0) # camelcase-required
delLines = attr.ib(default=0) # camelcase-required delLines = attr.ib(default=0) # camelcase-required
@attr.s
class phabchange(object):
"""Represents a Differential change, owns Differential hunks and owned by a
Differential diff. Each one represents one file in a diff.
"""
currentPath = attr.ib(default=None) # camelcase-required
oldPath = attr.ib(default=None) # camelcase-required
awayPaths = attr.ib(default=attr.Factory(list)) # camelcase-required
metadata = attr.ib(default=attr.Factory(dict))
oldProperties = attr.ib(default=attr.Factory(dict)) # camelcase-required
newProperties = attr.ib(default=attr.Factory(dict)) # camelcase-required
type = attr.ib(default=DiffChangeType.CHANGE)
fileType = attr.ib(default=DiffFileType.TEXT) # camelcase-required
commitHash = attr.ib(default=None) # camelcase-required
addLines = attr.ib(default=0) # camelcase-required
delLines = attr.ib(default=0) # camelcase-required
hunks = attr.ib(default=attr.Factory(list))
def copynewmetadatatoold(self):
for key in list(self.metadata.keys()):
newkey = key.replace(b'new:', b'old:')
self.metadata[newkey] = self.metadata[key]
def addoldmode(self, value):
self.oldProperties[b'unix:filemode'] = value
def addnewmode(self, value):
self.newProperties[b'unix:filemode'] = value
def addhunk(self, hunk):
if not isinstance(hunk, phabhunk):
raise error.Abort(b'phabchange.addhunk only takes phabhunks')
self.hunks.append(hunk)
# It's useful to include these stats since the Phab web UI shows them,
# and uses them to estimate how large a change a Revision is. Also used
# in email subjects for the [+++--] bit.
self.addLines += hunk.addLines
self.delLines += hunk.delLines
def creatediff(ctx): def creatediff(ctx):
"""create a Differential Diff""" """create a Differential Diff"""
repo = ctx.repo() repo = ctx.repo()
repophid = getrepophid(repo) repophid = getrepophid(repo)
# Create a "Differential Diff" via "differential.createrawdiff" API # Create a "Differential Diff" via "differential.createrawdiff" API
params = {b'diff': getdiff(ctx, mdiff.diffopts(git=True, context=32767))} params = {b'diff': getdiff(ctx, mdiff.diffopts(git=True, context=32767))}
if repophid: if repophid:
params[b'repositoryPHID'] = repophid params[b'repositoryPHID'] = repophid