This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7044

phabricator: add the phabdiff data structure
ClosedPublic

Authored by Kwan on Oct 10 2019, 5:52 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG75e7628b488f: phabricator: add the phabdiff data structure
Summary

This holds all the data about a commit, and is passed to the
differential.creatediff API.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Kwan created this revision.Oct 10 2019, 5:52 PM
Kwan updated this revision to Diff 17075.Oct 11 2019, 1:54 PM

Fix some test-check-code issues, and one test-check-pyflakes unused local.

indygreg accepted this revision.Oct 11 2019, 9:44 PM
This revision is now accepted and ready to land.Oct 11 2019, 9:44 PM
Kwan added a commit: rHG75e7628b488f: phabricator: add the phabdiff data structure.Oct 11 2019, 9:56 PM
Closed by commit rHG75e7628b488f: phabricator: add the phabdiff data structure (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (26 lines)

Diff 17050

hgext/phabricator.py

self.hunks.append(hunk) self.hunks.append(hunk)
# It's useful to include these stats since the Phab web UI shows them, # It's useful to include these stats since the Phab web UI shows them,
# and uses them to estimate how large a change a Revision is. Also used # and uses them to estimate how large a change a Revision is. Also used
# in email subjects for the [+++--] bit. # in email subjects for the [+++--] bit.
self.addLines += hunk.addLines self.addLines += hunk.addLines
self.delLines += hunk.delLines self.delLines += hunk.delLines
@attr.s
class phabdiff(object):
"""Represents a Differential diff, owns Differential changes. Corresponds
to a commit.
"""
# Doesn't seem to be any reason to send this (output of uname -n)
sourceMachine = attr.ib(default=b'')
sourcePath = attr.ib(default=b'/')
sourceControlBaseRevision = attr.ib(default=b'0' * 40)
sourceControlPath = attr.ib(default=b'/')
sourceControlSystem = attr.ib(default=b'hg')
branch = attr.ib(default=b'default')
bookmark = attr.ib(default=None)
creationMethod = attr.ib(default=b'phabsend')
lintStatus = attr.ib(default=b'none')
unitStatus = attr.ib(default=b'none')
changes = attr.ib(default=attr.Factory(dict))
repositoryPHID = attr.ib(default=None)
def addchange(self, change):
if not isinstance(change, phabchange):
raise error.Abort(b'phabdiff.addchange only takes phabchanges')
self.changes[change.currentPath] = change
def creatediff(ctx): def creatediff(ctx):
"""create a Differential Diff""" """create a Differential Diff"""
repo = ctx.repo() repo = ctx.repo()
repophid = getrepophid(repo) repophid = getrepophid(repo)
# Create a "Differential Diff" via "differential.createrawdiff" API # Create a "Differential Diff" via "differential.createrawdiff" API
params = {b'diff': getdiff(ctx, mdiff.diffopts(git=True, context=32767))} params = {b'diff': getdiff(ctx, mdiff.diffopts(git=True, context=32767))}
if repophid: if repophid:
params[b'repositoryPHID'] = repophid params[b'repositoryPHID'] = repophid