This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7259

statprof: correctly always pass a str as the thread name
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:55 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG5c9daf7df2b4: statprof: correctly always pass a str as the thread name
Summary

Caught by pytype.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 6 2019, 5:55 PM
indygreg accepted this revision.Nov 7 2019, 3:04 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:04 AM
durin42 added a commit: rHG5c9daf7df2b4: statprof: correctly always pass a str as the thread name.Nov 7 2019, 3:30 AM
Closed by commit rHG5c9daf7df2b4: statprof: correctly always pass a str as the thread name (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/statprof.py (2 lines)

Diff 17629

mercurial/statprof.py

signal.signal(signal.SIGPROF, profile_signal_handler) signal.signal(signal.SIGPROF, profile_signal_handler)
signal.setitimer( signal.setitimer(
signal.ITIMER_PROF, rpt or state.sample_interval, 0.0 signal.ITIMER_PROF, rpt or state.sample_interval, 0.0
) )
elif mechanism == b'thread': elif mechanism == b'thread':
frame = inspect.currentframe() frame = inspect.currentframe()
tid = [k for k, f in sys._current_frames().items() if f == frame][0] tid = [k for k, f in sys._current_frames().items() if f == frame][0]
state.thread = threading.Thread( state.thread = threading.Thread(
target=samplerthread, args=(tid,), name=b"samplerthread" target=samplerthread, args=(tid,), name="samplerthread"
) )
state.thread.start() state.thread.start()
def stop(): def stop():
'''Stop profiling, and uninstall the profiling signal handler.''' '''Stop profiling, and uninstall the profiling signal handler.'''
state.profile_level -= 1 state.profile_level -= 1
if state.profile_level == 0: if state.profile_level == 0: