This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	durin42	D7288 archival: suppress some incorrect pytype failures
Closed	durin42	D7287 simplemerge: disable a pytype error where it's just confused
Closed	durin42	D7286 match: suppress error about subscripting an exception
Closed	durin42	D7285 vfs: more attribute suppressions
Closed	durin42	D7284 mdiff: mark diffopts as having dynamic attributes
Closed	durin42	D7283 mail: suppress a pytype error that's just experimentally wrong
Closed	durin42	D7282 vfs: suppress some pytype errors around us using a private attribute
Closed	durin42	D7281 wireprototypes: disable pytype where it's just confused
Closed	durin42	D7280 scmposix: another suppression on IOError subscripting
Closed	durin42	D7279 pvec: add an explicit type hint to help pytype
Closed	durin42	D7278 procutil: suppress pytype warnings around windows-only attributes
Closed	durin42	D7277 dagparser: suppress some pytype errors around pycompat.bytestring
Closed	durin42	D7276 posix: add a pytype suppression
Closed	durin42	D7275 encoding: add comment-based type hints for pytype
Closed	durin42	D7274 color: suppress pytype warning on a windows-only module
Closed	durin42	D7273 compression: tell pytype to not sweat a missing `zstd` module
Closed	durin42	D7272 pytype: don't warn us about ignored-on-py3 metaclasses
Closed	durin42	D7271 linelog: be more careful about types before looking for _target attribute
Closed	durin42	D7270 linelog: suppress annoying pytype warning about an ignored metaclass
Closed	durin42	D7269 hgignore: ignore generated pytype stubs
Closed	durin42	D7268 hghave: add a check for pytype, Google's Python type checker
Closed	durin42	D7267 encoding: define local identify functions with explicit type comments
Closed	durin42	D7266 vfs: add NotImplementedError version of join
Closed	durin42	D7265 vfs: add a NotImplementedError implementation of __call__
Closed	durin42	D7264 vfs: fix erroneous bytes constants
Closed	durin42	D7263 pvec: migrate to modern integer division
Closed	durin42	D7262 templateutil: fix a missing ABCMeta assignment
Closed	durin42	D7261 pvec: fix overlooked chr() call
Closed	durin42	D7260 vfs: another bytes-str confusion on thread name
Closed	durin42	D7259 statprof: correctly always pass a str as the thread name

Diff 17643

mercurial/utils/compression.py

	def name(self):			def name(self):
	return b'zstd'			return b'zstd'

	@propertycache			@propertycache
	def _module(self):			def _module(self):
	# Not all installs have the zstd module available. So defer importing			# Not all installs have the zstd module available. So defer importing
	# until first access.			# until first access.
	try:			try:
	from .. import zstd			from .. import zstd # pytype: disable=import-error

	# Force delayed import.			# Force delayed import.
	zstd.__version__			zstd.__version__
	return zstd			return zstd
	except ImportError:			except ImportError:
	return None			return None

	def available(self):			def available(self):

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	17643		Nov 6 2019, 5:57 PM	★	★
Diff 2	17690	rHG9ce76155e0da6d39dbf9b063b689e75416061ee5	Nov 6 2019, 2:20 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

compression: tell pytype to not sweat a missing `zstd` moduleClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17643

mercurial/utils/compression.py

compression: tell pytype to not sweat a missing `zstd` module
ClosedPublic

Revision Contents
Changeset List