( )⚙ D7277 dagparser: suppress some pytype errors around pycompat.bytestring

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7277

dagparser: suppress some pytype errors around pycompat.bytestring
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:57 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG6d001f452bcb: dagparser: suppress some pytype errors around pycompat.bytestring
Summary

I can't justify why we're getting these errors, but nothing I do fixes
these handful of calls, so let's just move on with suppressions.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/dagparser.py (16 lines)

Diff 17647

mercurial/dagparser.py

>>> try: list(parsedag(b'+1 bad')) >>> try: list(parsedag(b'+1 bad'))
... except Exception as e: print(pycompat.sysstr(bytes(e))) ... except Exception as e: print(pycompat.sysstr(bytes(e)))
invalid character in dag description: bad... invalid character in dag description: bad...
''' '''
if not desc: if not desc:
return return
wordchars = pycompat.bytestr(string.ascii_letters + string.digits) wordchars = pycompat.bytestr(
string.ascii_letters + string.digits
) # pytype: disable=wrong-arg-types
labels = {} labels = {}
p1 = -1 p1 = -1
r = 0 r = 0
def resolve(ref): def resolve(ref):
if not ref: if not ref:
return p1 return p1
elif ref[0] in pycompat.bytestr(string.digits): elif ref[0] in pycompat.bytestr(
string.digits
): # pytype: disable=wrong-arg-types
return r - int(ref) return r - int(ref)
else: else:
return labels[ref] return labels[ref]
chiter = pycompat.iterbytestr(desc) chiter = pycompat.iterbytestr(desc)
def nextch(): def nextch():
return next(chiter, b'\0') return next(chiter, b'\0')
def nextstring(c): def nextstring(c):
if c == b'"': if c == b'"':
return nextdelimited(nextch(), b'"', b'\\') return nextdelimited(nextch(), b'"', b'\\')
else: else:
return nextrun(c, wordchars) return nextrun(c, wordchars)
c = nextch() c = nextch()
while c != b'\0': while c != b'\0':
while c in pycompat.bytestr(string.whitespace): while c in pycompat.bytestr(
string.whitespace
): # pytype: disable=wrong-arg-types
c = nextch() c = nextch()
if c == b'.': if c == b'.':
yield b'n', (r, [p1]) yield b'n', (r, [p1])
p1 = r p1 = r
r += 1 r += 1
c = nextch() c = nextch()
elif c == b'+': elif c == b'+':
c, digs = nextrun(nextch(), pycompat.bytestr(string.digits)) c, digs = nextrun(
nextch(), pycompat.bytestr(string.digits)
) # pytype: disable=wrong-arg-types
n = int(digs) n = int(digs)
for i in pycompat.xrange(0, n): for i in pycompat.xrange(0, n):
yield b'n', (r, [p1]) yield b'n', (r, [p1])
p1 = r p1 = r
r += 1 r += 1
elif c in b'*/': elif c in b'*/':
if c == b'*': if c == b'*':
c = nextch() c = nextch()