( )⚙ D7280 scmposix: another suppression on IOError subscripting

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7280

scmposix: another suppression on IOError subscripting
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:57 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG667f56d73ceb: scmposix: another suppression on IOError subscripting
Summary

As before, this will clear up when we move to Python 3-only.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 6 2019, 5:57 PM
indygreg accepted this revision.Nov 7 2019, 3:17 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:17 AM
durin42 added a commit: rHG667f56d73ceb: scmposix: another suppression on IOError subscripting.Nov 7 2019, 3:33 AM
Closed by commit rHG667f56d73ceb: scmposix: another suppression on IOError subscripting (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmposix.py (2 lines)

Diff 17694

mercurial/scmposix.py

continue continue
arri = fcntl.ioctl(fd, TIOCGWINSZ, b'\0' * 8) arri = fcntl.ioctl(fd, TIOCGWINSZ, b'\0' * 8)
height, width = array.array(r'h', arri)[:2] height, width = array.array(r'h', arri)[:2]
if width > 0 and height > 0: if width > 0 and height > 0:
return width, height return width, height
except ValueError: except ValueError:
pass pass
except IOError as e: except IOError as e:
if e[0] == errno.EINVAL: if e[0] == errno.EINVAL: # pytype: disable=unsupported-operands
pass pass
else: else:
raise raise
return 80, 24 return 80, 24