( )⚙ D7281 wireprototypes: disable pytype where it's just confused

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7281

wireprototypes: disable pytype where it's just confused
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:58 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGf5fcf7123a92: wireprototypes: disable pytype where it's just confused
Summary

By inspection validnames is always a Set[bytes] here, but for some
reason pytype is convinced it's a bytes. Let's disable the error for now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 6 2019, 5:58 PM
indygreg accepted this revision.Nov 7 2019, 3:17 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:17 AM
durin42 added a commit: rHGf5fcf7123a92: wireprototypes: disable pytype where it's just confused.Nov 7 2019, 3:33 AM
Closed by commit rHGf5fcf7123a92: wireprototypes: disable pytype where it's just confused (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprototypes.py (2 lines)

Diff 17696

mercurial/wireprototypes.py

if not compengines: if not compengines:
raise error.Abort( raise error.Abort(
_( _(
b'%s config option does not specify any known ' b'%s config option does not specify any known '
b'compression engines' b'compression engines'
) )
% config, % config,
hint=_(b'usable compression engines: %s') hint=_(b'usable compression engines: %s')
% b', '.sorted(validnames), % b', '.sorted(validnames), # pytype: disable=attribute-error
) )
return compengines return compengines
@attr.s @attr.s
class encodedresponse(object): class encodedresponse(object):
"""Represents response data that is already content encoded. """Represents response data that is already content encoded.