( )⚙ D7283 mail: suppress a pytype error that's just experimentally wrong

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7283

mail: suppress a pytype error that's just experimentally wrong
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:58 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG3b31ee5388f3: mail: suppress a pytype error that's just experimentally wrong
Summary

It's probably more correct to pass a str here, but I'm not going to
worry about it for now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 6 2019, 5:58 PM
indygreg accepted this revision.Nov 8 2019, 11:41 AM
This revision is now accepted and ready to land.Nov 8 2019, 11:41 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/mail.py (4 lines)

Diff 17788

mercurial/mail.py

return mimetextqp(s, subtype, b"iso-8859-1") return mimetextqp(s, subtype, b"iso-8859-1")
def mimetextqp(body, subtype, charset): def mimetextqp(body, subtype, charset):
'''Return MIME message. '''Return MIME message.
Quoted-printable transfer encoding will be used if necessary. Quoted-printable transfer encoding will be used if necessary.
''' '''
cs = email.charset.Charset(charset) # Experimentally charset is okay as a bytes even if the type
# stubs disagree.
cs = email.charset.Charset(charset) # pytype: disable=wrong-arg-types
msg = email.message.Message() msg = email.message.Message()
msg.set_type(pycompat.sysstr(b'text/' + subtype)) msg.set_type(pycompat.sysstr(b'text/' + subtype))
for line in body.splitlines(): for line in body.splitlines():
if len(line) > 950: if len(line) > 950:
cs.body_encoding = email.charset.QP cs.body_encoding = email.charset.QP
break break